Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16791
Ah, thank you for confirming and the information!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/16791
@HyukjinKwon Sorry that I didn't see your comment before this PR got
merged. I believe PARQUET-686 had already been fixed by apache/parquet-mr#367
but wasn't marked as resolved in JIRA. Thanks
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/16791
Merging in master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16791
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16791
BTW, LGTM for the changes in `ParquetSchrmaConverter` as i have the exact
same changes ready for a PR in my local. However, do you mind if I ask
PARQUET-686 is fixed in another JIRA? it seems
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16791
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72315/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16791
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16791
**[Test build #72315 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72315/testReport)**
for PR 16791 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/16791
I see. Sure!
Right, it happens only maven build so far.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/16791
I'll create another PR and ping you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/16791
I see, thanks for the context. But I'd like to keep this Maven build
failure fix in a separate PR so that people can easily cherry-pick the fix.
Also, it helps to keep this PR easier to follow.
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/16791
Yep. The failure is on #16751 . It's my bad.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/16791
Originally, it's reported at #16751 by @robbinspg .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/16791
Hope we finally have proper Parquet filter push-down for string/binary
columns (cross fingers)!
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/16791
Here,
https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test%20(Dashboard)/job/spark-master-test-maven-hadoop-2.7/2530/consoleFull
```
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/16791
@dongjoon-hyun Actually, could you please point me the Maven build failure?
I don't think this failure is caused by this PR, is it? Are you refering to
some existing PR introduced by some earlier
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/16791
@dongjoon-hyun Ah, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/16791
Great, @liancheng .
BTW, could you specify the test dependency like the following in this PR?
```
diff --git a/sql/core/pom.xml b/sql/core/pom.xml
index b8aa698090..f9acf815e3
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16791
**[Test build #72315 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72315/testReport)**
for PR 16791 at commit
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/16791
cc @cloud-fan @rxin @HyukjinKwon
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
20 matches
Mail list logo
