Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/17185
Good idea @gatorsmile . Thanks !!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17185
Let us discuss it in the JIRA
https://issues.apache.org/jira/browse/SPARK-25121
---
-
To unsubscribe, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17185
@skambha @dilipbiswal How about the hint resolution after supporting multi
part names?
---
-
To unsubscribe, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/17185
thanks, merging to master!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17185
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17185
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94353/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17185
**[Test build #94353 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94353/testReport)**
for PR 17185 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17185
**[Test build #94353 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94353/testReport)**
for PR 17185 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/17185
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17185
**[Test build #94335 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94335/testReport)**
for PR 17185 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17185
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17185
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94335/
Test FAILed.
---
Github user skambha commented on the issue:
https://github.com/apache/spark/pull/17185
Thanks for the review. I have addressed your comments and pushed the
changes.
@cloud-fan, Please take a look.
---
-
To
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17185
**[Test build #94335 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94335/testReport)**
for PR 17185 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/17185
LGTM except some code style comment, thanks for working on it!
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17185
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94244/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17185
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17185
**[Test build #94244 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94244/testReport)**
for PR 17185 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17185
**[Test build #94244 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94244/testReport)**
for PR 17185 at commit
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/17185
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17185
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17185
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94234/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17185
**[Test build #94234 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94234/testReport)**
for PR 17185 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17185
**[Test build #94234 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94234/testReport)**
for PR 17185 at commit
Github user skambha commented on the issue:
https://github.com/apache/spark/pull/17185
I have addressed the review comments in this commit
[here](https://github.com/apache/spark/pull/17185/commits/065687f3b987e254f41279d45f0cced6e42e)
@cloud-fan, please take a look.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17185
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94206/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17185
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17185
**[Test build #94206 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94206/testReport)**
for PR 17185 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17185
**[Test build #94206 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94206/testReport)**
for PR 17185 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17185
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17185
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17185
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94187/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17185
**[Test build #94187 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94187/testReport)**
for PR 17185 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17185
**[Test build #94187 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94187/testReport)**
for PR 17185 at commit
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/17185
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17185
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17185
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94172/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17185
**[Test build #94172 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94172/testReport)**
for PR 17185 at commit
Github user skambha commented on the issue:
https://github.com/apache/spark/pull/17185
The last push has changes that adds the map lookup for the 3 part name. It
implements a solution to address the lookup.. although I think there are more
ways we can go about it and could possibly
Github user skambha commented on the issue:
https://github.com/apache/spark/pull/17185
I rebased and ran the catalyst unit test suite only as a sanity test.
fwiw, I had run the sql and hive and catalyst suites earlier prior to this last
rebase.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17185
**[Test build #94172 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94172/testReport)**
for PR 17185 at commit
Github user skambha commented on the issue:
https://github.com/apache/spark/pull/17185
Looks like there is another change that has gone in that this PR conflicts
with so the build fails. :(
I will rebase again and push.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17185
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94162/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17185
**[Test build #94162 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94162/testReport)**
for PR 17185 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17185
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17185
**[Test build #94160 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94160/testReport)**
for PR 17185 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17185
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94160/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17185
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17185
**[Test build #94162 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94162/testReport)**
for PR 17185 at commit
Github user skambha commented on the issue:
https://github.com/apache/spark/pull/17185
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17185
**[Test build #94160 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94160/testReport)**
for PR 17185 at commit
Github user skambha commented on the issue:
https://github.com/apache/spark/pull/17185
Thanks @cloud-fan for the review.
I am working on implementing an idea to get optimized lookup with 3part
name.
---
-
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/17185
overall LGTM, my major concern is how to do O(1) lookup for the 3 part name
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17185
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17185
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93904/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17185
**[Test build #93904 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93904/testReport)**
for PR 17185 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17185
**[Test build #93904 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93904/testReport)**
for PR 17185 at commit
Github user skambha commented on the issue:
https://github.com/apache/spark/pull/17185
I rebased and found out that the resolution code in Logical plan has
changed and it uses map lookup to do the matching. I have some ideas on how to
incorporate the 3 part name with the map lookup
Github user skambha commented on the issue:
https://github.com/apache/spark/pull/17185
@gatorsmile , @cloud-fan, just a quick comment, I have been working on
this and will respond soon.
---
-
To unsubscribe,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17185
Build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17185
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93810/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17185
**[Test build #93810 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93810/testReport)**
for PR 17185 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17185
**[Test build #93810 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93810/testReport)**
for PR 17185 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17185
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17185
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user mafernandez-stratio commented on the issue:
https://github.com/apache/spark/pull/17185
@gatorsmile Great, thanks for the feedback!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17185
@mafernandez-stratio We plan to review and merge after 2.3 release. The
target release will be 2.4
---
-
To unsubscribe,
Github user mafernandez-stratio commented on the issue:
https://github.com/apache/spark/pull/17185
Any plans of merging this PR?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17185
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86899/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17185
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17185
**[Test build #86899 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86899/testReport)**
for PR 17185 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17185
**[Test build #86899 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86899/testReport)**
for PR 17185 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17185
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user skambha commented on the issue:
https://github.com/apache/spark/pull/17185
I have rebased and pushed the changes. I ran the unit tests ( sql,
catalyst and hive).
Earlier, I was having issues running the hive test suite locally but that
is resolved with the fix from
Github user skambha commented on the issue:
https://github.com/apache/spark/pull/17185
sure. Let me look into it. Thanks.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/17185
I agree it's a valid use case, do you wanna bring it up to date? sorry for
the delay!
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17185
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17185
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user skambha commented on the issue:
https://github.com/apache/spark/pull/17185
cc @gatorsmile, @cloud-fan I'd really appreciate your review and
comments. Thanks much.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17185
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
80 matches
Mail list logo
