[GitHub] spark issue #17336: [SPARK-20003] [ML] FPGrowthModel setMinConfidence should...

2017-04-04 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/17336 Thanks a lot for the second update! This LGTM Merging with master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #17336: [SPARK-20003] [ML] FPGrowthModel setMinConfidence should...

2017-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17336 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75517/ Test PASSed. ---

[GitHub] spark issue #17336: [SPARK-20003] [ML] FPGrowthModel setMinConfidence should...

2017-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17336 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17336: [SPARK-20003] [ML] FPGrowthModel setMinConfidence should...

2017-04-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17336 **[Test build #75517 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75517/testReport)** for PR 17336 at commit

[GitHub] spark issue #17336: [SPARK-20003] [ML] FPGrowthModel setMinConfidence should...

2017-04-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17336 **[Test build #75517 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75517/testReport)** for PR 17336 at commit

[GitHub] spark issue #17336: [SPARK-20003] [ML] FPGrowthModel setMinConfidence should...

2017-04-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17336 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75448/ Test PASSed. ---

[GitHub] spark issue #17336: [SPARK-20003] [ML] FPGrowthModel setMinConfidence should...

2017-04-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17336 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17336: [SPARK-20003] [ML] FPGrowthModel setMinConfidence should...

2017-04-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17336 **[Test build #75448 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75448/testReport)** for PR 17336 at commit

[GitHub] spark issue #17336: [SPARK-20003] [ML] FPGrowthModel setMinConfidence should...

2017-04-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17336 **[Test build #75448 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75448/testReport)** for PR 17336 at commit

[GitHub] spark issue #17336: [SPARK-20003] [ML] FPGrowthModel setMinConfidence should...

2017-03-31 Thread hhbyyh
Github user hhbyyh commented on the issue: https://github.com/apache/spark/pull/17336 The major thing I'm concerned is that `transform` will have to recompute the association rules each time it's invoked. If that's not a problem, changing association rules to method would be much

[GitHub] spark issue #17336: [SPARK-20003] [ML] FPGrowthModel setMinConfidence should...

2017-03-31 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/17336 Thanks for this PR! Do you think it's worth adding the caching logic? I'm now wondering if we should change associationRules into a method which recomputes the DataFrame every time it is

[GitHub] spark issue #17336: [SPARK-20003] [ML] FPGrowthModel setMinConfidence should...

2017-03-30 Thread hhbyyh
Github user hhbyyh commented on the issue: https://github.com/apache/spark/pull/17336 ping @jkbradley as this is something we should fix before release. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark issue #17336: [SPARK-20003] [ML] FPGrowthModel setMinConfidence should...

2017-03-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17336 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74995/ Test PASSed. ---

[GitHub] spark issue #17336: [SPARK-20003] [ML] FPGrowthModel setMinConfidence should...

2017-03-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17336 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17336: [SPARK-20003] [ML] FPGrowthModel setMinConfidence should...

2017-03-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17336 **[Test build #74995 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74995/testReport)** for PR 17336 at commit

[GitHub] spark issue #17336: [SPARK-20003] [ML] FPGrowthModel setMinConfidence should...

2017-03-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17336 **[Test build #74995 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74995/testReport)** for PR 17336 at commit

[GitHub] spark issue #17336: [SPARK-20003] [ML] FPGrowthModel setMinConfidence should...

2017-03-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17336 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74752/ Test PASSed. ---

[GitHub] spark issue #17336: [SPARK-20003] [ML] FPGrowthModel setMinConfidence should...

2017-03-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17336 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17336: [SPARK-20003] [ML] FPGrowthModel setMinConfidence should...

2017-03-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17336 **[Test build #74752 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74752/testReport)** for PR 17336 at commit

[GitHub] spark issue #17336: [SPARK-20003] [ML] FPGrowthModel setMinConfidence should...

2017-03-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17336 **[Test build #74752 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74752/testReport)** for PR 17336 at commit

[GitHub] spark issue #17336: [SPARK-20003] [ML] FPGrowthModel setMinConfidence should...

2017-03-17 Thread hhbyyh
Github user hhbyyh commented on the issue: https://github.com/apache/spark/pull/17336 ping @jkbradley and @srowen to be aware of the issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have