Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17350
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user zhaorongsheng commented on the issue:
https://github.com/apache/spark/pull/17350
@gatorsmile Sorry for the late reply.
I have checked all the functions' nullability setting and I didn't found
any issue.
Thanks~
---
If your project is set up for it, you can reply
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17350
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user zhaorongsheng commented on the issue:
https://github.com/apache/spark/pull/17350
@gatorsmile OK, I will do it and I will give you feedback as soon as
possible.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17350
@zhaorongsheng Not sure whether you can help us check whether all the
functions have an issue in nullability setting?
---
If your project is set up for it, you can reply to this email and have
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17350
LGTM
Since it is very close to code freeze, let me merge it to master and 2.1 at
first. You can submit the PR to address the issues as a follow-up PR. Thanks!
---
If your project is
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17350
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74986/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17350
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17350
**[Test build #74986 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74986/testReport)**
for PR 17350 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17350
**[Test build #74986 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74986/testReport)**
for PR 17350 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17350
Thank you for updating the example, but you forgot to update the function
description.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17350
Add the queries to the following file: `string-function.sql`
Run the following command
```
SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "sql/test-only *SQLQueryTestSuite"
```
Github user wzhfy commented on the issue:
https://github.com/apache/spark/pull/17350
@hvanhovell Got it. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user zhaorongsheng commented on the issue:
https://github.com/apache/spark/pull/17350
@gatorsmile Is it OK? I don't know how to add test case in
string-function.sql. ï¼·ould you give me some guidance? Thanks~
---
If your project is set up for it, you can reply to this email
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/17350
@wzhfy why wouldn't we change the nullability? This is obviously a bug in
the current master:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17350
Also, add an end-to-end test case in string-function.sql. Update the
function description to explain when we return null.
---
If your project is set up for it, you can reply to this email and
Github user wzhfy commented on the issue:
https://github.com/apache/spark/pull/17350
May I ask why you want to change the nullability of StringToMap?
also cc @gatorsmile
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/17350
@hvanhovell could you check?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user zhaorongsheng commented on the issue:
https://github.com/apache/spark/pull/17350
@maropu The test case is added. Please check it, thanks~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/17350
Could you add tests?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17350
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
21 matches
Mail list logo
