Github user rxin commented on the issue:
https://github.com/apache/spark/pull/17399
@roxannemoslehi can you fix the title? We can then merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/17399
Yea we definitely need a better title. Thanks for contributing though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user ash211 commented on the issue:
https://github.com/apache/spark/pull/17399
Thanks for contributing to Spark @roxannemoslehi !
I think Sean just means updating the title to something more like `[DOCS]
Clarify round mode in format_number function`. It doesn't feel
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/17399
No I really meant fill out the PR a little more (see link). The title isn't
descriptive.
If you mean this is just making the docs consistent that's great, just note
that in the description here.
Github user roxannemoslehi commented on the issue:
https://github.com/apache/spark/pull/17399
Hmm @srowen do you mean describe HALF_EVEN round mode? Also, I know some of
the other functions that use this type of rounding already include it in their
definition.
---
If your project
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/17399
Have a look at http://spark.apache.org/contributing.html as the template
says.
I think you'd want to describe this a little more, and consider whether
other functions could use this detail?
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17399
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
