[GitHub] spark issue #17432: [SPARK-20086][SQL] CollapseWindow should not collapse de...

2017-03-26 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17432 Thank you! uh, I have another case with different data types. That is why I did not correctly reproduce it. The project is not removed due to data type mismatches. : ) ```Scala val d

[GitHub] spark issue #17432: [SPARK-20086][SQL] CollapseWindow should not collapse de...

2017-03-26 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/17432 The project will get eliminated by the optimizer. From the JIRA ticket: ```scala import org.apache.spark.sql.expressions.Window val win_spec_max = Window.partitionBy("x").orderBy(

[GitHub] spark issue #17432: [SPARK-20086][SQL] CollapseWindow should not collapse de...

2017-03-26 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17432 @hvanhovell Could you share a Scala end-to-end test case for reproducing the error? If using `withColumn`, we always insert a `Project` between two `Window`s. Not sure why the users hit this issu

[GitHub] spark issue #17432: [SPARK-20086][SQL] CollapseWindow should not collapse de...

2017-03-26 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/17432 Thank you for fixing this! It seems that this should be included in RC2. When will be cut for RC2? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark issue #17432: [SPARK-20086][SQL] CollapseWindow should not collapse de...

2017-03-26 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/17432 Thanks for the review. Merging this to master/2.1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] spark issue #17432: [SPARK-20086][SQL] CollapseWindow should not collapse de...

2017-03-26 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/17432 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] spark issue #17432: [SPARK-20086][SQL] CollapseWindow should not collapse de...

2017-03-26 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/17432 cc @cloud-fan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark issue #17432: [SPARK-20086][SQL] CollapseWindow should not collapse de...

2017-03-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17432 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17432: [SPARK-20086][SQL] CollapseWindow should not collapse de...

2017-03-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17432 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75233/ Test PASSed. ---

[GitHub] spark issue #17432: [SPARK-20086][SQL] CollapseWindow should not collapse de...

2017-03-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17432 **[Test build #75233 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75233/testReport)** for PR 17432 at commit [`500c26f`](https://github.com/apache/spark/commit/5

[GitHub] spark issue #17432: [SPARK-20086][SQL] CollapseWindow should not collapse de...

2017-03-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17432 **[Test build #75233 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75233/testReport)** for PR 17432 at commit [`500c26f`](https://github.com/apache/spark/commit/50

[GitHub] spark issue #17432: [SPARK-20086][SQL] CollapseWindow should not collapse de...

2017-03-26 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/17432 cc @dongjoon-hyun --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so