Github user srowen commented on the issue:
https://github.com/apache/spark/pull/17459
Merged to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17459
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17459
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77606/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17459
**[Test build #77606 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77606/testReport)**
for PR 17459 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17459
**[Test build #77606 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77606/testReport)**
for PR 17459 at commit
Github user johnc1231 commented on the issue:
https://github.com/apache/spark/pull/17459
@srowen @viirya All comments addressed, back to you guys. Hopefully we've
just about reached something ready to commit.
---
If your project is set up for it, you can reply to this email and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17459
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77439/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17459
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17459
**[Test build #77439 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77439/testReport)**
for PR 17459 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17459
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17459
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77437/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17459
**[Test build #77437 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77437/testReport)**
for PR 17459 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17459
**[Test build #77439 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77439/testReport)**
for PR 17459 at commit
Github user johnc1231 commented on the issue:
https://github.com/apache/spark/pull/17459
@srowen Fixed both, back to you
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17459
**[Test build #77437 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77437/testReport)**
for PR 17459 at commit
Github user johnc1231 commented on the issue:
https://github.com/apache/spark/pull/17459
@srowen Addressed comments, back to you. And thanks for taking time to look
this over.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user johnc1231 commented on the issue:
https://github.com/apache/spark/pull/17459
This has been reviewed pretty thoroughly at this point. Can a committer
give this a quick look? @srowen @MLnick @jkbradley I think it's basically ready
to go in.
---
If your project is set up
Github user johnc1231 commented on the issue:
https://github.com/apache/spark/pull/17459
Also, made changes suggested by @srowen . Don't know if he now has to sign
off on those changes being done.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user johnc1231 commented on the issue:
https://github.com/apache/spark/pull/17459
@viirya Now that style nitpicks and sparse benchmarks are done, are you
good with this? Also, per your recommendation, CCing @MLnick and @jkbradley for
review of this. Should be easy to review,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17459
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76504/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17459
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17459
**[Test build #76504 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76504/testReport)**
for PR 17459 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17459
**[Test build #76504 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76504/testReport)**
for PR 17459 at commit
Github user johnc1231 commented on the issue:
https://github.com/apache/spark/pull/17459
@viirya Addressed style nitpicks and did spark benchmarks. Think that
should be everything.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user johnc1231 commented on the issue:
https://github.com/apache/spark/pull/17459
Did a sparse benchmark (2014 Macbook Pro with 2.2Hz i7) 60 partitions, 10k
by 10k matrix with mostly 0's, 10% 1's, made of SparseVectors. Both old method
and new method took about 7.5 seconds.
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/17459
Except for few comments regarding style, the code changes LGTM.
And it'd be good if we can have benchmark for sparse case too.
cc @MLnick @jkbradley for review.
---
If your project
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/17459
@johnc1231 Thanks for updating this. I'll review it in the weekend.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user johnc1231 commented on the issue:
https://github.com/apache/spark/pull/17459
@viirya Any more feedback on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user johnc1231 commented on the issue:
https://github.com/apache/spark/pull/17459
@viirya I fixed the test as you asked, so please take a look when you get a
chance. I'm having a little bit of trouble with my local spark build for some
reason, but I'll do that other benchmark
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17459
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17459
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76107/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17459
**[Test build #76107 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76107/testReport)**
for PR 17459 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17459
**[Test build #76107 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76107/testReport)**
for PR 17459 at commit
Github user johnc1231 commented on the issue:
https://github.com/apache/spark/pull/17459
@viirya
Gonna fix that last test tonight, but just doing a quick timing on my
laptop, (2014 Macbook Pro with 2.2Hz i7), the difference was as follows on a
10k by 10k matrix of random doubles
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17459
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75754/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17459
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17459
**[Test build #75754 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75754/testReport)**
for PR 17459 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/17459
Only one remaining comment left for the test.
Btw, @johnc1231 Do you think it is possible you can run a simple benchmark,
so we know whether this change improves the performance too?
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17459
**[Test build #75754 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75754/testReport)**
for PR 17459 at commit
Github user johnc1231 commented on the issue:
https://github.com/apache/spark/pull/17459
@viirya Do you have any more comments on this, or are you happy with it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17459
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75575/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17459
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17459
**[Test build #75575 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75575/testReport)**
for PR 17459 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17459
**[Test build #75575 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75575/testReport)**
for PR 17459 at commit
Github user johnc1231 commented on the issue:
https://github.com/apache/spark/pull/17459
@viirya Added appropriate tests, back to you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
45 matches
Mail list logo
