Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/17469
Also cherry-picked this to branch-2.2.
cc @gatorsmile
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/17469
LGTM, thanks for your work on this @map222 & thanks for your work reviewing
this @HyukjinKwon.
Merged to master.
---
If your project is set up for it, you can reply to this email and have
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/17469
@holdenk
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/17469
LGTM if committers are okay with merging fixing some of documentation (not
all) but regarding it is his very first contribution.
---
If your project is set up for it, you can reply to this
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17469
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76075/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17469
**[Test build #76075 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76075/testReport)**
for PR 17469 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17469
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17469
**[Test build #76075 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76075/testReport)**
for PR 17469 at commit
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/17469
I don't why Jenkins doesn't pick up the changes automatically...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/17469
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user map222 commented on the issue:
https://github.com/apache/spark/pull/17469
Ok, I added ignore_unicode_prefix to the 6 functions, and it passed local
tests. I think it is ready for Jenkins again.
---
If your project is set up for it, you can reply to this email and have
Github user zero323 commented on the issue:
https://github.com/apache/spark/pull/17469
You'll have to use it on the wrapped function. Like:
contains = ignore_unicode_prefix(_bin_op("contains"))
---
If your project is set up for it, you can reply to this email and
Github user map222 commented on the issue:
https://github.com/apache/spark/pull/17469
@zero323 Aaaah, I had even identified what I needed to do! So I just need
to decorate `_unary_op` and `_bin_op`, yes?
---
If your project is set up for it, you can reply to this email and have your
Github user zero323 commented on the issue:
https://github.com/apache/spark/pull/17469
@map222
[`ignore_unicode_prefix`](https://github.com/apache/spark/blob/8ddf0d2a60795a2306f94df8eac6e265b1fe5230/python/pyspark/rdd.py#L146-L156)
---
If your project is set up for it, you can reply
Github user map222 commented on the issue:
https://github.com/apache/spark/pull/17469
The documentation unit test is now failing due to differences in python 2
and 3 strings. This is one of the error messages using the python 3.4 kernel:
```File
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17469
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75955/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17469
**[Test build #75955 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75955/testReport)**
for PR 17469 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17469
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17469
**[Test build #75955 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75955/testReport)**
for PR 17469 at commit
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/17469
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user map222 commented on the issue:
https://github.com/apache/spark/pull/17469
@holdenk @srowen Could I get a Jenkins test for this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/17469
Usually, it more makes sense to handle the similar instances in one place.
If you are easily able to add them, probably, it is a good place to put them
all. If it is currently difficult, I
Github user map222 commented on the issue:
https://github.com/apache/spark/pull/17469
I'd be happy to add other documentation, but I would also like to get my
first commit in! If you make a separate ticket to track that would help.
---
If your project is set up for it, you can reply
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/17469
I think we need @holdenk's sign-off though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/17469
It looks good to me if it passes the test. I could request filling up other
documentation as well but if it is difficult to run the tests in local machine
and regarding (I assume) it is the
Github user map222 commented on the issue:
https://github.com/apache/spark/pull/17469
I can't get the test failure to replicate on my local machine. Running
`./python/run-tests.py --modules=pyspark-sql` locally doesn't give any errors.
The previous failure was due to not having
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/17469
I've added @felixcheung to Jenkins as a GHPRB admin so now he should be
able to trigger Jenkins requests as well :)
---
If your project is set up for it, you can reply to this email and have your
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17469
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17469
**[Test build #75723 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75723/testReport)**
for PR 17469 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17469
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75723/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17469
**[Test build #75723 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75723/testReport)**
for PR 17469 at commit
Github user JoshRosen commented on the issue:
https://github.com/apache/spark/pull/17469
jenkins retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/17469
@map222, thanks, I don't have a permission to retrigger the build and know
why it does not automatically from the newly pushed commit. Would be great if
@srowen or @holdenk are able to
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/17469
@map222, thanks, I don't have a permission to retrigger the build and know
why it does not. Would be great if @srowen or @holdenk are able to retrigger
the build.
---
If your project is set
Github user map222 commented on the issue:
https://github.com/apache/spark/pull/17469
@HyukjinKwon I have updated the documentation to pass the tests (I didn't
realize the tests actually executed the documented code!). I was able to build
Spark locally, and run `./python/run-tests.py
Github user map222 commented on the issue:
https://github.com/apache/spark/pull/17469
@HyukjinKwon The Jenkins test failed. I'm having trouble running the tests
locally (I can't build Spark yet), and I can't decipher the Jenkins error
messages. Does something jump out to you?
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17469
**[Test build #75622 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75622/testReport)**
for PR 17469 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17469
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75622/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17469
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/17469
Great! I'll still follow up with Shane & Josh re: @felixcheung triggering
build as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/17469
Yes, it seems from your comment @holdenk.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/17469
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17469
**[Test build #75622 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75622/testReport)**
for PR 17469 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/17469
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/17469
I've e-mailed them since the Jenkins configuration is a bit too involved
(and I'd need Shane to sign off on any Jenkins change anyways). Sorry this is
slowing down your PR @map222 and thank you so
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/17469
Jenkins retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/17469
No your correct. The tooling around Jenkins hasn't had enough love as of
late since there are plans to replace a lot of it, so newer committers aren't
always added everywhere they need to be. I've
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/17469
It is little bit funny that some contibutors appearntly are able to trigger
the build (at least I saw a contributor made a comment "retest this please" and
it triggers the build) whereas some
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/17469
I'll take a look at Jenkins and see if I can figure out why it isn't
working - but I don't have a lot of experience coaxing Jenkins.
---
If your project is set up for it, you can reply to this
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/17469
I don't know, let me ping @joshrosen and see what's going on.
Jenkins retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/17469
It seems somethine goes wrong with @holdnk and Jenkins. I think I dont have
a permission to trigger this.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user map222 commented on the issue:
https://github.com/apache/spark/pull/17469
@HyukjinKwon Do I need to do something to start the Jenkins test?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/17469
Jenkins OK to test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user map222 commented on the issue:
https://github.com/apache/spark/pull/17469
I think the latest commit addresses the formatting issues from above:
removed spaces insides `(..)`, removed the `\n` newlines, and made the
blockquotes more consistent with the rest of the code.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/17469
It might be better to run`./dev/lint-python` locally if possible. There
will catch more of minor nits ahead.
---
If your project is set up for it, you can reply to this email and have your
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/17469
Also, you could run the python tests via `./python/run-tests.py --module
pyspark-sql` for python tests after building. It is fine because I guess
Jenkins will catch this but it might be nicer
56 matches
Mail list logo
