[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

2017-04-03 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/17487 Merging in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

2017-04-03 Thread samelamin
Github user samelamin commented on the issue: https://github.com/apache/spark/pull/17487 perfect! Can it be merged then? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

2017-04-03 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17487 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

2017-04-03 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17487 LGTM cc @hvanhovell @cloud-fan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

2017-04-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17487 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

2017-04-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17487 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75481/ Test PASSed. ---

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

2017-04-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17487 **[Test build #75481 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75481/testReport)** for PR 17487 at commit

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

2017-04-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17487 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

2017-04-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17487 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75480/ Test FAILed. ---

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

2017-04-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17487 **[Test build #75480 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75480/testReport)** for PR 17487 at commit

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

2017-04-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17487 **[Test build #75481 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75481/testReport)** for PR 17487 at commit

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

2017-04-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17487 **[Test build #75480 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75480/testReport)** for PR 17487 at commit

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

2017-04-03 Thread selamin
Github user selamin commented on the issue: https://github.com/apache/spark/pull/17487 @gatorsmile thanks so much for that, i spent over 2 hours getting that sql file correct manually! what was frustrating was after all that i had to revert my changes 😢 Atleast I know

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

2017-04-02 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17487 See the [code changes](https://github.com/apache/spark/commit/d9c24b3dc5ca64cf8aecebf58f22a3a2e5aab821) I made in my private branch. To generate the new result file after you add the

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

2017-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17487 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

2017-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17487 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75463/ Test PASSed. ---

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

2017-04-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17487 **[Test build #75463 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75463/testReport)** for PR 17487 at commit

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

2017-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17487 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75462/ Test PASSed. ---

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

2017-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17487 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

2017-04-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17487 **[Test build #75462 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75462/testReport)** for PR 17487 at commit

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

2017-04-02 Thread samelamin
Github user samelamin commented on the issue: https://github.com/apache/spark/pull/17487 FYI I can squash these commits to clean up the history once we agree on how best to approach the testing --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

2017-04-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17487 **[Test build #75463 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75463/testReport)** for PR 17487 at commit

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

2017-04-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17487 **[Test build #75462 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75462/testReport)** for PR 17487 at commit

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

2017-04-02 Thread samelamin
Github user samelamin commented on the issue: https://github.com/apache/spark/pull/17487 Maybe @gatorsmile or @srowen have an idea. How can I test the case insensitive unresolvedTableValuedFunction without using a var for the functionName. I'm open to all ideas folks! introducing a

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

2017-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17487 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

2017-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17487 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75460/ Test PASSed. ---

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

2017-04-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17487 **[Test build #75460 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75460/testReport)** for PR 17487 at commit

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

2017-04-02 Thread samelamin
Github user samelamin commented on the issue: https://github.com/apache/spark/pull/17487 Ok I was planning on doing that but unfortunately all the tests don't go through the resolveTableValuedFuntion but new up an UnTableValued. I totally agree with you with regards to state. What we

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

2017-04-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17487 **[Test build #75460 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75460/testReport)** for PR 17487 at commit

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

2017-04-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17487 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

2017-04-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17487 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75453/ Test FAILed. ---

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

2017-04-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17487 **[Test build #75453 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75453/testReport)** for PR 17487 at commit

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

2017-04-01 Thread samelamin
Github user samelamin commented on the issue: https://github.com/apache/spark/pull/17487 based on comments from @hvanhovell I am depending on the case sensitivity setting of the analyser. That said I had to make the functionName a var to change the value to lower case which feels

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

2017-03-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17487 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

2017-03-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17487 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75426/ Test FAILed. ---

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

2017-03-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17487 **[Test build #75426 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75426/testReport)** for PR 17487 at commit

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

2017-03-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17487 **[Test build #75426 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75426/testReport)** for PR 17487 at commit

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

2017-03-31 Thread samelamin
Github user samelamin commented on the issue: https://github.com/apache/spark/pull/17487 I'm not sure to be honest. But even if it is, the inbuilt functions has a key of "range" So anything else won't be found which is causing the problem in the first place

[GitHub] spark issue #17487: [Spark-20145] Fix range case insensitive bug in SQL

2017-03-31 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/17487 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if