[GitHub] spark issue #17532: [SPARK-20214][ML] Make sure converted csc matrix has sor...

2017-04-05 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/17532 LGTM Merging with master and branch-2.1, branch-2.0 Thanks a lot! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #17532: [SPARK-20214][ML] Make sure converted csc matrix has sor...

2017-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17532 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17532: [SPARK-20214][ML] Make sure converted csc matrix has sor...

2017-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17532 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75560/ Test PASSed. ---

[GitHub] spark issue #17532: [SPARK-20214][ML] Make sure converted csc matrix has sor...

2017-04-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17532 **[Test build #75560 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75560/testReport)** for PR 17532 at commit

[GitHub] spark issue #17532: [SPARK-20214][ML] Make sure converted csc matrix has sor...

2017-04-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17532 **[Test build #75560 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75560/testReport)** for PR 17532 at commit

[GitHub] spark issue #17532: [SPARK-20214][ML] Make sure converted csc matrix has sor...

2017-04-05 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/17532 @jkbradley An unit test is added. Please check this again. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark issue #17532: [SPARK-20214][ML] Make sure converted csc matrix has sor...

2017-04-05 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/17532 @jkbradley Thanks for comment. I will add the unit test now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark issue #17532: [SPARK-20214][ML] Make sure converted csc matrix has sor...

2017-04-05 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/17532 Btw, I'd really like to get this into 2.2, which will be cut soon. Let me know if you'd like me to take it over. Thanks! --- If your project is set up for it, you can reply to this email and

[GitHub] spark issue #17532: [SPARK-20214][ML] Make sure converted csc matrix has sor...

2017-04-05 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/17532 Are you able to write a unit test which passes data through _convert_to_vector and fails before this fix? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark issue #17532: [SPARK-20214][ML] Make sure converted csc matrix has sor...

2017-04-04 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/17532 I don't think is directly related, but, I tried to make a similar change to the Spark Scala implementation of this type of conversion and couldn't make it work, just because it changed a bunch of

[GitHub] spark issue #17532: [SPARK-20214][ML] Make sure converted csc matrix has sor...

2017-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17532 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17532: [SPARK-20214][ML] Make sure converted csc matrix has sor...

2017-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17532 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75530/ Test PASSed. ---

[GitHub] spark issue #17532: [SPARK-20214][ML] Make sure converted csc matrix has sor...

2017-04-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17532 **[Test build #75530 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75530/testReport)** for PR 17532 at commit

[GitHub] spark issue #17532: [SPARK-20214][ML] Make sure converted csc matrix has sor...

2017-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17532 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75528/ Test PASSed. ---

[GitHub] spark issue #17532: [SPARK-20214][ML] Make sure converted csc matrix has sor...

2017-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17532 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17532: [SPARK-20214][ML] Make sure converted csc matrix has sor...

2017-04-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17532 **[Test build #75528 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75528/testReport)** for PR 17532 at commit

[GitHub] spark issue #17532: [SPARK-20214][ML] Make sure converted csc matrix has sor...

2017-04-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17532 **[Test build #75530 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75530/testReport)** for PR 17532 at commit

[GitHub] spark issue #17532: [SPARK-20214][ML] Make sure converted csc matrix has sor...

2017-04-04 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/17532 cc @jkbradley @MLnick @holdenk --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #17532: [SPARK-20214][ML] Make sure converted csc matrix has sor...

2017-04-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17532 **[Test build #75528 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75528/testReport)** for PR 17532 at commit