[GitHub] spark issue #17626: [SPARK-20315] [SQL] Set ScalaUDF's deterministic to true...

2017-04-13 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17626 After I rethinking about it, it really depends on how we define `deterministic`. I checked the definition of Hive `UDFType`. ``` /** * Certain optimizations should not

[GitHub] spark issue #17626: [SPARK-20315] [SQL] Set ScalaUDF's deterministic to true...

2017-04-12 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/17626 `udf(x, y) = 1` is deterministic no matter whether x or y is deterministic or not, is because x, y are not used, in other words they don't affect the result of the udf. The result of

[GitHub] spark issue #17626: [SPARK-20315] [SQL] Set ScalaUDF's deterministic to true...

2017-04-12 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17626 The deterministic of our [Scala udaf has exactly the same

[GitHub] spark issue #17626: [SPARK-20315] [SQL] Set ScalaUDF's deterministic to true...

2017-04-12 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17626 A simple example, `udf(x, y) = 1` is deterministic no matter whether x or y is deterministic or not. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark issue #17626: [SPARK-20315] [SQL] Set ScalaUDF's deterministic to true...

2017-04-12 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/17626 udf(x, y) = x + y looks like a deterministic UDF function. Is this udf(rand(), rand()) deterministic? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark issue #17626: [SPARK-20315] [SQL] Set ScalaUDF's deterministic to true...

2017-04-12 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17626 Even if the input expressions are not deterministic, the output could be still deterministic. If we already make an assumption that ScalaUDF is deterministic, we should make it behave

[GitHub] spark issue #17626: [SPARK-20315] [SQL] Set ScalaUDF's deterministic to true...

2017-04-12 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/17626 Hmm, I think it is a bit different between the deterministic assumption on UDF functions and the `deterministic` of `ScalaUDF`. Even your UDF functions are deterministic, if the input

[GitHub] spark issue #17626: [SPARK-20315] [SQL] Set ScalaUDF's deterministic to true...

2017-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17626 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17626: [SPARK-20315] [SQL] Set ScalaUDF's deterministic to true...

2017-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17626 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75753/ Test PASSed. ---

[GitHub] spark issue #17626: [SPARK-20315] [SQL] Set ScalaUDF's deterministic to true...

2017-04-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17626 **[Test build #75753 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75753/testReport)** for PR 17626 at commit

[GitHub] spark issue #17626: [SPARK-20315] [SQL] Set ScalaUDF's deterministic to true...

2017-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17626 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75752/ Test PASSed. ---

[GitHub] spark issue #17626: [SPARK-20315] [SQL] Set ScalaUDF's deterministic to true...

2017-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17626 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17626: [SPARK-20315] [SQL] Set ScalaUDF's deterministic to true...

2017-04-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17626 **[Test build #75752 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75752/testReport)** for PR 17626 at commit

[GitHub] spark issue #17626: [SPARK-20315] [SQL] Set ScalaUDF's deterministic to true...

2017-04-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17626 **[Test build #75753 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75753/testReport)** for PR 17626 at commit

[GitHub] spark issue #17626: [SPARK-20315] [SQL] Set ScalaUDF's deterministic to true...

2017-04-12 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17626 cc @cloud-fan @dongjoon-hyun --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #17626: [SPARK-20315] [SQL] Set ScalaUDF's deterministic to true...

2017-04-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17626 **[Test build #75752 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75752/testReport)** for PR 17626 at commit