Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17649
Could you update the PR description and title?
This PR is to fix the issue in modify table comments using ALTER TABLE
SET/UNSET TBLPROPERTIES, instead of fixing the DESC FORMATTED, right
Github user sujith71955 commented on the issue:
https://github.com/apache/spark/pull/17649
@wzhfy @gatorsmile fixed all the comments, thanks for reviewing the
changes and providing me valuable sharings and comments. thanks.
---
If your project is set up for it, you can reply to this
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17649
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76496/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17649
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17649
**[Test build #76496 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76496/testReport)**
for PR 17649 at commit
[`4f02ada`](https://github.com/apache/spark/commit/4
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17649
**[Test build #76496 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76496/testReport)**
for PR 17649 at commit
[`4f02ada`](https://github.com/apache/spark/commit/4f
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17649
LGTM except a few minor comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enable
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17649
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17649
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76458/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17649
**[Test build #76458 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76458/testReport)**
for PR 17649 at commit
[`433ac2b`](https://github.com/apache/spark/commit/4
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17649
**[Test build #76458 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76458/testReport)**
for PR 17649 at commit
[`433ac2b`](https://github.com/apache/spark/commit/43
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17649
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76385/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17649
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17649
**[Test build #76385 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76385/testReport)**
for PR 17649 at commit
[`f0e9173`](https://github.com/apache/spark/commit/f
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17649
**[Test build #76385 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76385/testReport)**
for PR 17649 at commit
[`f0e9173`](https://github.com/apache/spark/commit/f0
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17649
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17649
**[Test build #76353 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76353/testReport)**
for PR 17649 at commit
[`f5209f5`](https://github.com/apache/spark/commit/f
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17649
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76353/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17649
**[Test build #76353 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76353/testReport)**
for PR 17649 at commit
[`f5209f5`](https://github.com/apache/spark/commit/f5
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17649
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17649
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76350/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17649
**[Test build #76350 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76350/testReport)**
for PR 17649 at commit
[`510ce05`](https://github.com/apache/spark/commit/5
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17649
**[Test build #76350 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76350/testReport)**
for PR 17649 at commit
[`510ce05`](https://github.com/apache/spark/commit/51
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17649
@wzhfy In HiveClientImpl.scala, we follow Hive and consider the case
sensitivity of property key `comment`.
@sujith71955 Could you resolve the following comment?
https://github.com/
Github user wzhfy commented on the issue:
https://github.com/apache/spark/pull/17649
The changes look good to me if we don't care about the case sensitivity
issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user sujith71955 commented on the issue:
https://github.com/apache/spark/pull/17649
@gatorsmile @wzhfy updated the PR by removing the 'comment' from table
properties .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17649
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17649
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76142/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17649
**[Test build #76142 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76142/testReport)**
for PR 17649 at commit
[`99ba5be`](https://github.com/apache/spark/commit/9
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17649
**[Test build #76142 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76142/testReport)**
for PR 17649 at commit
[`99ba5be`](https://github.com/apache/spark/commit/99
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17649
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17649
**[Test build #76139 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76139/testReport)**
for PR 17649 at commit
[`1156483`](https://github.com/apache/spark/commit/1
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17649
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76139/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17649
**[Test build #76139 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76139/testReport)**
for PR 17649 at commit
[`1156483`](https://github.com/apache/spark/commit/11
Github user wzhfy commented on the issue:
https://github.com/apache/spark/pull/17649
@gatorsmile Hive treats comment simply as a key in the string-string
parameter map, while spark extracts comment from the map as a field in
`CatalogTable`. So the question is, should spark consider bo
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17649
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76085/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17649
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17649
**[Test build #76085 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76085/testReport)**
for PR 17649 at commit
[`50deed9`](https://github.com/apache/spark/commit/5
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17649
**[Test build #76085 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76085/testReport)**
for PR 17649 at commit
[`50deed9`](https://github.com/apache/spark/commit/50
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17649
@wzhfy Could you check the behavior of Hive?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user wzhfy commented on the issue:
https://github.com/apache/spark/pull/17649
@gatorsmile Should we care about case sensitivity of comment? Hive allows
both "comment" and "Comment" in table parameters, while we are extracting
comment as a field of `CatalogTable`.
---
If your
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17649
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76004/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17649
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17649
**[Test build #76004 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76004/testReport)**
for PR 17649 at commit
[`19d80c6`](https://github.com/apache/spark/commit/1
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17649
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17649
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76002/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17649
**[Test build #76002 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76002/testReport)**
for PR 17649 at commit
[`467a694`](https://github.com/apache/spark/commit/4
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17649
**[Test build #76004 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76004/testReport)**
for PR 17649 at commit
[`19d80c6`](https://github.com/apache/spark/commit/19
Github user sujith71955 commented on the issue:
https://github.com/apache/spark/pull/17649
@gatorsmile @wzhfy updated the PR based on the review comments, please let
me know for any suggestions.
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17649
**[Test build #76002 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76002/testReport)**
for PR 17649 at commit
[`467a694`](https://github.com/apache/spark/commit/46
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17649
Any update?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or i
51 matches
Mail list logo
