Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/17836
Sure!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if th
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/17836
to be safe, can we create a new PR for 2.2? thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/17836
It's cherry-pickable into branch-2.2.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/17836
Hi, @cloud-fan .
Apache Spark 2.2 seems to be passed now.
Do you think it is possible to backport this into `branch-2.2` for 2.2.1?
---
If your project is set up for it, you can reply
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/17836
Thank you for review and merging again, @kiszk and @cloud-fan .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/17836
thanks, merging to master!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wi
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/17836
Thanks, LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17836
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76438/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17836
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17836
**[Test build #76438 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76438/testReport)**
for PR 17836 at commit
[`2b58c9f`](https://github.com/apache/spark/commit/2
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17836
**[Test build #76438 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76438/testReport)**
for PR 17836 at commit
[`2b58c9f`](https://github.com/apache/spark/commit/2b
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/17836
Sure, @kiszk . I'll update the other test suite to improve coverage.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17836
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17836
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76411/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17836
**[Test build #76411 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76411/testReport)**
for PR 17836 at commit
[`6cec5da`](https://github.com/apache/spark/commit/6
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/17836
Good catch. Is is better to apply these changes to other types (e.g. null,
boolean, byte, short, int, and long)?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/17836
I updated the test cases to include
`appendFloat/appendFloats/appendDouble/appendDoubles`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17836
**[Test build #76411 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76411/testReport)**
for PR 17836 at commit
[`6cec5da`](https://github.com/apache/spark/commit/6c
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/17836
Thank you, @michal-databricks and @viirya .
It was my mistake. I thought I did all. :(
I'll add that correctly, too.
---
If your project is set up for it, you can reply to this email a
Github user michal-databricks commented on the issue:
https://github.com/apache/spark/pull/17836
Not sure if intentional, but the added test ("Float APIs") does not cover
the new function (is uses put API mostly). Actually as far as I can see
the "appends" APIs are not used at all in
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/17836
Thank you for review, @hvanhovell and @cloud-fan .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/17836
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/17836
cc @michal-databricks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishe
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17836
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17836
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76404/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17836
**[Test build #76404 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76404/testReport)**
for PR 17836 at commit
[`d979d0f`](https://github.com/apache/spark/commit/d
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/17836
Thank you for review, @kiszk
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/17836
LGTM
cc: @sameeragarwal @cloud-fan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabl
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17836
**[Test build #76404 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76404/testReport)**
for PR 17836 at commit
[`d979d0f`](https://github.com/apache/spark/commit/d9
29 matches
Mail list logo
