[GitHub] spark issue #17874: [SPARK-20612][SQL] Throw exception when there is unresol...

2017-05-08 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17874 yea that example looks very weird and we should fix it, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark issue #17874: [SPARK-20612][SQL] Throw exception when there is unresol...

2017-05-08 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/17874 @cloud-fan Since you all concern about breaking existing applications, I'd close this. But I think we should not add missing attributes though subqueries like I showed above. I'll create another PR

[GitHub] spark issue #17874: [SPARK-20612][SQL] Throw exception when there is unresol...

2017-05-07 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/17874 Maybe another point of view is, we can split `df.select("y").where("x=1")` to two different DataFrames: val onlyY = df.select("y") // The schema of onlyY is just "y" attribute

[GitHub] spark issue #17874: [SPARK-20612][SQL] Throw exception when there is unresol...

2017-05-07 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/17874 `select a from t where b > 0` works. However, it can be seen logically as: Project [a] Filter [b > 0] Relation t [a, b] It seems to me Spark also parses the

[GitHub] spark issue #17874: [SPARK-20612][SQL] Throw exception when there is unresol...

2017-05-07 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17874 in postgres, `select a from t where b > 0` can work, I think it's reasonable if `df.select("y").where("x=1")` works in spark. ``` Seq(1).toDF("c1").createOrReplaceTempView("onerow")

[GitHub] spark issue #17874: [SPARK-20612][SQL] Throw exception when there is unresol...

2017-05-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17874 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17874: [SPARK-20612][SQL] Throw exception when there is unresol...

2017-05-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17874 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76538/ Test PASSed. ---

[GitHub] spark issue #17874: [SPARK-20612][SQL] Throw exception when there is unresol...

2017-05-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17874 **[Test build #76538 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76538/testReport)** for PR 17874 at commit