[GitHub] spark issue #18037: [SPARK-20814][mesos] Restore support for spark.executor....

2017-05-22 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/18037 I'm gonna merge this to unblock 2.2; if there's a desire to clean up this code later, we can do it separately. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark issue #18037: [SPARK-20814][mesos] Restore support for spark.executor....

2017-05-22 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/18037 YARN does not run `spark-class`, Mesos does. And `spark-class` does not honor `CLASSPATH`, IIRC. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark issue #18037: [SPARK-20814][mesos] Restore support for spark.executor....

2017-05-22 Thread mgummelt
Github user mgummelt commented on the issue: https://github.com/apache/spark/pull/18037 It looks like YARN just sets the generic java `CLASSPATH` env var. Maybe Mesos should do that too. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark issue #18037: [SPARK-20814][mesos] Restore support for spark.executor....

2017-05-22 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/18037 Neither standalone nor YARN use env variables to create the executor's classpath, so I guess that's why Mesos was missed. I'd rather Mesos stop using env variables too, but that's a bigger change,

[GitHub] spark issue #18037: [SPARK-20814][mesos] Restore support for spark.executor....

2017-05-22 Thread mgummelt
Github user mgummelt commented on the issue: https://github.com/apache/spark/pull/18037 It looks like Standalone gets around this by constructing a raw `java` command instead of a `spark-class` command. Will YARN be using this new `SPARK_EXECUTOR_CLASSPATH` variable as well?

[GitHub] spark issue #18037: [SPARK-20814][mesos] Restore support for spark.executor....

2017-05-22 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/18037 Yes, it just set `SPARK_CLASSPATH` and relied on the launcher code to respect that env variable, but that code was recently removed. --- If your project is set up for it, you can reply to this

[GitHub] spark issue #18037: [SPARK-20814][mesos] Restore support for spark.executor....

2017-05-22 Thread mgummelt
Github user mgummelt commented on the issue: https://github.com/apache/spark/pull/18037 Was spark.executor.extraClassPath ever supported in Mesos? I see no code for it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark issue #18037: [SPARK-20814][mesos] Restore support for spark.executor....

2017-05-22 Thread mgummelt
Github user mgummelt commented on the issue: https://github.com/apache/spark/pull/18037 looking... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark issue #18037: [SPARK-20814][mesos] Restore support for spark.executor....

2017-05-22 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/18037 Ping? Let me invoke @srowen or @squito since we should have this in 2.2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #18037: [SPARK-20814][mesos] Restore support for spark.executor....

2017-05-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18037 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77129/ Test PASSed. ---

[GitHub] spark issue #18037: [SPARK-20814][mesos] Restore support for spark.executor....

2017-05-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18037 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18037: [SPARK-20814][mesos] Restore support for spark.executor....

2017-05-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18037 **[Test build #77129 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77129/testReport)** for PR 18037 at commit

[GitHub] spark issue #18037: [SPARK-20814][mesos] Restore support for spark.executor....

2017-05-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18037 **[Test build #77129 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77129/testReport)** for PR 18037 at commit

[GitHub] spark issue #18037: [SPARK-20814][mesos] Restore support for spark.executor....

2017-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18037 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77106/ Test PASSed. ---

[GitHub] spark issue #18037: [SPARK-20814][mesos] Restore support for spark.executor....

2017-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18037 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18037: [SPARK-20814][mesos] Restore support for spark.executor....

2017-05-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18037 **[Test build #77106 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77106/testReport)** for PR 18037 at commit

[GitHub] spark issue #18037: [SPARK-20814][mesos] Restore support for spark.executor....

2017-05-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18037 **[Test build #77106 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77106/testReport)** for PR 18037 at commit

[GitHub] spark issue #18037: [SPARK-20814][mesos] Restore support for spark.executor....

2017-05-19 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/18037 @mgummelt --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the