[GitHub] spark issue #18236: [SPARK-21015] Check field name is not null and empty in ...

2017-06-11 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18236 How about just updating the comment of this function to explain the behavior we have now? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark issue #18236: [SPARK-21015] Check field name is not null and empty in ...

2017-06-11 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/spark/pull/18236 @rxin @HyukjinKwon Thank you looking into this PR :D Maybe I don't make it clearly : `GenericRowWithSchema` fetch field with field name and the field name shouldn't null or empty .

[GitHub] spark issue #18236: [SPARK-21015] Check field name is not null and empty in ...

2017-06-10 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18236 It looks we already throw the same exception with what this PR proposes as below: ```scala import org.apache.spark.sql.catalyst.expressions.GenericRowWithSchema import

[GitHub] spark issue #18236: [SPARK-21015] Check field name is not null and empty in ...

2017-06-09 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/18236 Why do we want this check? If the user passes in null value, it is ok if it is not found, isn't it? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark issue #18236: [SPARK-21015] Check field name is not null and empty in ...

2017-06-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18236 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this