Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18266
Thanks! Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18266
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/18266
@gatorsmile Done
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18266
@wangyum Could you update the example in the PR description?
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18266
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18266
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81719/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18266
**[Test build #81719 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81719/testReport)**
for PR 18266 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18266
**[Test build #81719 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81719/testReport)**
for PR 18266 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18266
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18266
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81601/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18266
**[Test build #81601 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81601/testReport)**
for PR 18266 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18266
**[Test build #81601 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81601/testReport)**
for PR 18266 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18266
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18266
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81536/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18266
**[Test build #81536 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81536/testReport)**
for PR 18266 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18266
**[Test build #81536 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81536/testReport)**
for PR 18266 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18266
will review this today.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/18266
Yes, mapping to Double seems fine. this test passed:
```
test("SPARK-20427/SPARK-20921: read table use custom schema by jdbc api")
{
// default will throw IllegalArgumentException
Github user sobusiak commented on the issue:
https://github.com/apache/spark/pull/18266
As far as I understand the proposed solution recommends using `DecimalType`
with user-chosen precision and scale but `DecimalType` cannot represent all
numbers that can be stored in NUMBER. I
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18266
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18266
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81084/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18266
**[Test build #81084 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81084/testReport)**
for PR 18266 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18266
**[Test build #81084 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81084/testReport)**
for PR 18266 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18266
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81031/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18266
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18266
**[Test build #81031 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81031/testReport)**
for PR 18266 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18266
**[Test build #81031 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81031/testReport)**
for PR 18266 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18266
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81024/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18266
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18266
**[Test build #81024 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81024/testReport)**
for PR 18266 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18266
**[Test build #81024 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81024/testReport)**
for PR 18266 at commit
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/18266
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18266
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18266
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81019/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18266
**[Test build #81019 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81019/testReport)**
for PR 18266 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18266
**[Test build #81019 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81019/testReport)**
for PR 18266 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18266
**[Test build #81017 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81017/testReport)**
for PR 18266 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18266
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81017/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18266
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18266
**[Test build #81017 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81017/testReport)**
for PR 18266 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18266
**[Test build #81015 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81015/testReport)**
for PR 18266 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18266
**[Test build #81015 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81015/testReport)**
for PR 18266 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18266
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80743/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18266
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18266
**[Test build #80743 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80743/testReport)**
for PR 18266 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18266
So far, we do not want to introduce the user-specified schema to `CREATE
TEMPORARY VIEW`, but we might do it in the other formats in the data source API
v2.
---
If your project is set up for
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/18266
How about below? similar to [Hive
JDBCStorageHandler](https://github.com/apache/hive/blob/rel/release-2.3.0/ql/src/test/queries/clientpositive/jdbc_handler.q#L1-L17):
```sql
CREATE TEMPORARY
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18266
**[Test build #80743 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80743/testReport)**
for PR 18266 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18266
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80731/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18266
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18266
**[Test build #80731 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80731/testReport)**
for PR 18266 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18266
**[Test build #80731 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80731/testReport)**
for PR 18266 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18266
Users should be allowed to specify the schema from the table properties by
using DDL-like strings.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18266
The example in the PR description looks a little bit confusing.
```Scala
val dfRead = spark.read.schema(schema).jdbc(jdbcUrl,
"tableWithCustomSchema", new Properties())
```
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18266
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79136/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18266
Build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18266
**[Test build #79136 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79136/testReport)**
for PR 18266 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18266
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79137/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18266
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18266
**[Test build #79137 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79137/testReport)**
for PR 18266 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18266
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18266
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79139/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18266
**[Test build #79139 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79139/testReport)**
for PR 18266 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18266
**[Test build #79139 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79139/testReport)**
for PR 18266 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18266
**[Test build #79137 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79137/testReport)**
for PR 18266 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18266
**[Test build #79136 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79136/testReport)**
for PR 18266 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18266
I am fine to support customized schema for read path of JDBC relation.
However, we need to check whether the user-specified schema matches the
underlying the table schema. If not matched, we
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18266
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78526/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18266
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18266
**[Test build #78526 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78526/testReport)**
for PR 18266 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18266
**[Test build #78526 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78526/testReport)**
for PR 18266 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18266
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78093/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18266
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18266
**[Test build #78093 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78093/testReport)**
for PR 18266 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18266
**[Test build #78093 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78093/testReport)**
for PR 18266 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18266
**[Test build #77908 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77908/testReport)**
for PR 18266 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18266
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77908/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18266
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18266
**[Test build #77908 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77908/testReport)**
for PR 18266 at commit
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/18266
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/18266
retest please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18266
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77895/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18266
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18266
**[Test build #77895 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77895/testReport)**
for PR 18266 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18266
**[Test build #77895 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77895/testReport)**
for PR 18266 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18266
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18266
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77887/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18266
**[Test build #77887 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77887/testReport)**
for PR 18266 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18266
**[Test build #77887 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77887/testReport)**
for PR 18266 at commit
89 matches
Mail list logo
