Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/18557
Yep. It's totally internal officially.
What I meant with `performance issue` is 3rd party can still use it and
there might be a performance gap between `float` and `double`.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/18557
`ColumnVector` is total internal in Spark 2.2, so there won't be 3rd party
Spark library issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/18557
BTW, thank you for swift reviews and feedbacks on my PR. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/18557
I know that 'there is no usage of this API internally in Spark 2.2', but
it's only for 2.2.0.
My reason was any 3rd party Spark library cannot use `ColumnVector` for
`float` type in Spark
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/18557
I've changed the ticket type from `bug` to `improvement`, adding a new API
is not fixing a bug.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/18557
We have not seen any failure in test suites. And, [there is no usage of
this API](https://github.com/apache/spark/pull/17836#discussion_r114488839) in
Spark 2.2.
Does this missing cause any
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/18557
Hi, @kiszk .
I think this is a bug fix of `ColumnVector` as described in
[SPARK-20566](https://issues.apache.org/jira/browse/SPARK-20566).
---
If your project is set up for it, you can
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/18557
@dongjoon-hyun Is there any reason to backport this to previous versions?
This is because we had such [a
discussion](https://github.com/apache/spark/pull/17836#pullrequestreview-35957231).
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/18557
Hi, @cloud-fan .
This is the backport for #17836 .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18557
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18557
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79306/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18557
**[Test build #79306 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79306/testReport)**
for PR 18557 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18557
**[Test build #79306 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79306/testReport)**
for PR 18557 at commit
13 matches
Mail list logo
