Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/18576
thanks, merging to master!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/18576
ping
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/18576
I checked if we could fix the join issue:
https://github.com/apache/spark/commit/c4ca4f3dbcc69b7bccb9e1b093dd8488d15eedee
---
-
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/18576
@cloud-fan Iâm ganna to fix the join stuffs described in your comment in
following prs, ok?
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18576
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18576
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88772/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18576
**[Test build #88772 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88772/testReport)**
for PR 18576 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18576
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18576
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1876/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18576
**[Test build #88772 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88772/testReport)**
for PR 18576 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18576
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18576
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88665/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18576
**[Test build #88665 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88665/testReport)**
for PR 18576 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18576
**[Test build #88665 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88665/testReport)**
for PR 18576 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18576
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18576
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1806/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18576
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88662/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18576
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18576
**[Test build #88662 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88662/testReport)**
for PR 18576 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18576
**[Test build #88662 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88662/testReport)**
for PR 18576 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18576
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18576
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1803/
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/18576
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18576
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18576
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88657/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18576
**[Test build #88657 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88657/testReport)**
for PR 18576 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18576
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18576
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1798/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18576
**[Test build #88657 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88657/testReport)**
for PR 18576 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18576
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18576
**[Test build #88653 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88653/testReport)**
for PR 18576 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18576
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88653/
Test FAILed.
---
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/18576
An alternative solution is
[here](https://github.com/apache/spark/compare/master...maropu:SPARK-21351-5)
and this is based on [the
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18576
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18576
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1795/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18576
**[Test build #88653 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88653/testReport)**
for PR 18576 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/18576
ok, I'll do.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/18576
I think it can fix
https://github.com/apache/spark/pull/20687/files#diff-b801a310eb00e432983248c9978ff924R343
@maropu do you wanna bring it up to date? thanks!
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18576
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85761/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18576
Build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18576
**[Test build #85761 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85761/testReport)**
for PR 18576 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18576
**[Test build #85761 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85761/testReport)**
for PR 18576 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18576
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18576
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85032/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18576
**[Test build #85032 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85032/testReport)**
for PR 18576 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18576
**[Test build #85032 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85032/testReport)**
for PR 18576 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/18576
could u please also give me any suggestion? (welcome any suggestion, e.g.,
we don't need this for now and others.). @gatorsmile
---
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/18576
kindly ping
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/18576
ping
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/18576
@gatorsmile How about this kind of impl.?
https://github.com/apache/spark/compare/master...maropu:SPARK-21351-5
---
-
To
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/18576
ok, will look this around based on the suggestion.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18576
Changing the usage/semantics of `output` is risky. It could easily break
the existing codes without notice, especially when you do not completely remove
`output` from `QueryPlan`.
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/18576
@gatorsmile I think a bit more about this issue and I propose another
approach; how about just moving `output` into `QueryPlanConstraints` and
`output` always considering NULL constraints in its own
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/18576
yea, I also think `nullability` has good effects on many places as you
suggested, so we better propagate this info correctly as much as possible. But,
the plan nodes in the current implementation
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18576
Conceptually, nullability of each column is still a hint to Spark SQL. In
the constraint inference, we also add `ISNOTNULL` in
[`constructIsNotNullConstraints`
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/18576
ok, I'll rethink the design of this pr again. Thanks~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18576
The codes in this PR look still intrusive. We need to decouple it from the
interface of the operators. Is it possible to use something like
`LogicalPlanVisitor`?
---
If your project is set up
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/18576
ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/18576
Many thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18576
Will review it in the next few days
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/18576
ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/18576
@gatorsmile ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18576
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80315/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18576
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18576
**[Test build #80315 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80315/testReport)**
for PR 18576 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18576
**[Test build #80315 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80315/testReport)**
for PR 18576 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/18576
I'm looking into the failure reason...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18576
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18576
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80305/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18576
**[Test build #80305 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80305/testReport)**
for PR 18576 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18576
**[Test build #80305 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80305/testReport)**
for PR 18576 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18576
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80304/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18576
**[Test build #80304 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80304/testReport)**
for PR 18576 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18576
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18576
**[Test build #80304 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80304/testReport)**
for PR 18576 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18576
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80303/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18576
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18576
**[Test build #80303 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80303/testReport)**
for PR 18576 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18576
**[Test build #80303 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80303/testReport)**
for PR 18576 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18576
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80293/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18576
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18576
**[Test build #80293 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80293/testReport)**
for PR 18576 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18576
**[Test build #80293 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80293/testReport)**
for PR 18576 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/18576
Yea, if we can do so, I feel it might be the best. I'll check if we can
remove nullability update in `FilterExec`.
---
If your project is set up for it, you can reply to this email and have your
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18576
If we can update the nullability in Optimizer rules, do we still need to do
it in `FilterExec`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/18576
@gatorsmile If you get time, could you also check this? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/18576
ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18576
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79463/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18576
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18576
**[Test build #79463 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79463/testReport)**
for PR 18576 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18576
**[Test build #79463 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79463/testReport)**
for PR 18576 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/18576
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18576
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18576
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79449/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18576
**[Test build #79449 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79449/testReport)**
for PR 18576 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18576
**[Test build #79449 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79449/testReport)**
for PR 18576 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/18576
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18576
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79445/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18576
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18576
**[Test build #79445 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79445/testReport)**
for PR 18576 at commit
1 - 100 of 115 matches
Mail list logo
