Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18728
merged to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18728
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79941/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18728
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18728
**[Test build #79941 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79941/testReport)**
for PR 18728 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18728
**[Test build #79941 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79941/testReport)**
for PR 18728 at commit
Github user hhbyyh commented on the issue:
https://github.com/apache/spark/pull/18728
That appears to be all right. Sending update.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18728
How about extending just `org.scalatest.Assertions`? if that doesn't work,
I'd just forget it, sure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user hhbyyh commented on the issue:
https://github.com/apache/spark/pull/18728
Yes, that's good. But I just found there's one rule in the scala style
check
"Tests must extend org.apache.spark.SparkFunSuite instead."
try to ignore it?
---
If your project is set up for
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18728
What about only extending, say, `FunSuite`? there's probably something
higher in the hierarchy that would suffice, if all that's really used is ===.
Tightening this up a bit might be useful.
---
Github user hhbyyh commented on the issue:
https://github.com/apache/spark/pull/18728
Thanks for your attention. @srowen
The temp dir cleanup function is implemented in trait
`DefaultReadWriteTest` which extends `TempDirectory`, not from `SparkFunSuite`.
And as you said, the
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18728
Hm, is the more basic error here that `object ValidatorParamsSuiteHelpers
extends SparkFunSuite` ? it seems like it's trying to leverage the temp dir
cleanup function in the superclass, but it will
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18728
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18728
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79920/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18728
**[Test build #79920 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79920/testReport)**
for PR 18728 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18728
**[Test build #79920 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79920/testReport)**
for PR 18728 at commit
15 matches
Mail list logo
