Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/18797
Merged into master and branch-2.2. Thanks for all.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18797
**[Test build #3884 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3884/testReport)**
for PR 18797 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18797
**[Test build #3884 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3884/testReport)**
for PR 18797 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18797
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80381/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18797
**[Test build #80381 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80381/testReport)**
for PR 18797 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18797
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18797
**[Test build #80381 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80381/testReport)**
for PR 18797 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18797
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80369/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18797
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18797
**[Test build #80369 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80369/testReport)**
for PR 18797 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18797
**[Test build #80369 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80369/testReport)**
for PR 18797 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18797
Yes it seems like that should be checked somewhere. It might be rational to
include it here as a double check that the newly uncovered issue that needs to
be fixed to upgrade breeze is gone. But
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/18797
@srowen @WeichenXu123
It make sense to remove the datum with label 0, as we compute
```log(label)``` which may lead to ```-Infinity``` and eventually causes the
error. Thanks for catching
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18797
@WeichenXu123 looks like we need one other tiny tweak to the Python
equivalents. There I think it's easiest to convert a 0 to a tiny value:
```
diff --git
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18797
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80259/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18797
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18797
**[Test build #80259 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80259/testReport)**
for PR 18797 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18797
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80258/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18797
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18797
**[Test build #80258 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80258/testReport)**
for PR 18797 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18797
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18797
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80257/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18797
**[Test build #80257 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80257/testReport)**
for PR 18797 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18797
**[Test build #80259 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80259/testReport)**
for PR 18797 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18797
**[Test build #80258 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80258/testReport)**
for PR 18797 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18797
@WeichenXu123 there is one more change you'll need, in
`AFTSurvivalRegressionSuite.scala` to also remove a datum with label 0
---
If your project is set up for it, you can reply to this email and
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18797
**[Test build #80257 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80257/testReport)**
for PR 18797 at commit
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/18797
@srowen Great! thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18797
[aft.txt](https://github.com/apache/spark/files/1200479/aft.txt)
@WeichenXu123 it does appear that the tests pass with the following tiny
changes -- I can make a proper PR on your
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18797
Yeah, the only issue is that the test set is generated and used in several
tests. Maybe we can just see if changing it works for all callers.
---
If your project is set up for it, you can reply to
Github user BenFradet commented on the issue:
https://github.com/apache/spark/pull/18797
@srowen there shouldn't be any issue with removing the first row of the
test data afaict.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/18797
Thanks! Waiting AFT testcode author to figure out how to modify the
testcase.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18797
I've figured out the problem, and pretty sure it's a problem in the AFT
test that was hidden until now. It runs AFTSurvivlaRegression on this input:
```
++-+--+--+
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18797
The only number that is <= Double.PositiveInfinity is Double.NaN, because
it has no ordering at all with respect to anything. So init must be NaN somehow.
It's called from LBFGS in Breeze,
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/18797
@srowen Yeah, the third case is another problem (I think we can simply
change the iter num 7 to 6 in testcase)
I am curious about the first two cases, why trigger the require fail ? By
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18797
The actual failure in the first two cases looks like it must be related:
```
sbt.ForkMain$ForkError: java.lang.IllegalArgumentException: requirement
failed: init value should <= bound
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/18797
Strange thing, the code failed this `require` at
https://github.com/scalanlp/breeze/blob/master/math/src/main/scala/breeze/optimize/StrongWolfe.scala#L73
in the three case:
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18797
Ah, looks like some legitimate failures related to the change we pulled in.
Probably just needs some test adjustments
---
If your project is set up for it, you can reply to this email and have your
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18797
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80125/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18797
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18797
**[Test build #80125 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80125/testReport)**
for PR 18797 at commit
41 matches
Mail list logo
