Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/18940
+1, I'm going to merge as it appears all comments addressed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18940
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18940
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80931/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18940
**[Test build #80931 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80931/testReport)**
for PR 18940 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18940
**[Test build #80931 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80931/testReport)**
for PR 18940 at commit
Github user redsanket commented on the issue:
https://github.com/apache/spark/pull/18940
@vanzin addressed the config comment thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/18940
LGTM, also cc @cloud-fan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/18940
+1. Any further comments. @vanzin @jiangxb1987
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18940
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18940
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80696/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18940
**[Test build #80696 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80696/testReport)**
for PR 18940 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18940
**[Test build #80696 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80696/testReport)**
for PR 18940 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18940
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80691/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18940
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18940
**[Test build #80691 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80691/testReport)**
for PR 18940 at commit
Github user redsanket commented on the issue:
https://github.com/apache/spark/pull/18940
Thanks @vanzin @kiszk will do, makes sense to me now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/18940
If you're removing a public config, you should at least add it to
`SparkConf.deprecatedConfigs`. It would be nice, but not required, to have some
kind of mapping of the old value to the new (in
Github user redsanket commented on the issue:
https://github.com/apache/spark/pull/18940
@kiszk wouldn't the updated release notes/docs take care of that, which
configs can no longer be used and which are not. I don't mind adding a warning
msg saying please use another cache.size
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/18940
@redsanket I am thinking about the case that the same configuration file,
which explicitly sets a value (e.g. 4096) into
`spark.shuffle.service.index.cache.entries`, is used in Spark 2.3.
The
Github user redsanket commented on the issue:
https://github.com/apache/spark/pull/18940
@kiszk I dont think that would be ideal, it is better to backport the
feature itself to a desired version or branch, having two conflicting configs
for the same task is not ideal, if that is what
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/18940
nit: title should be "`[SPARK-21501] ...`".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/18940
I like this feature.
For backward compatibility, how about referring to
`spark.shuffle.service.index.cache.entries` only if
`spark.shuffle.service.index.cache.entries` is explicitly declared.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18940
**[Test build #80691 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80691/testReport)**
for PR 18940 at commit
Github user redsanket commented on the issue:
https://github.com/apache/spark/pull/18940
@dbolshak there were no unit tests for google cache implementation here
before, I could add a simple test to check for cache behavior if it is
necessary but ideally a scale test is necessary to
24 matches
Mail list logo
