[GitHub] spark issue #19064: [SPARK-21848][SQL] Add trait UDFType to identify user-de...

2017-08-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19064 **[Test build #81204 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81204/testReport)** for PR 19064 at commit

[GitHub] spark issue #19064: [SPARK-21848][SQL] Add trait UDFType to identify user-de...

2017-08-29 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/19064 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #19064: [SPARK-21848][SQL] Add trait UDFType to identify user-de...

2017-08-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19064 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #19064: [SPARK-21848][SQL] Add trait UDFType to identify user-de...

2017-08-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19064 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81202/ Test FAILed. ---

[GitHub] spark issue #19064: [SPARK-21848][SQL] Add trait UDFType to identify user-de...

2017-08-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19064 **[Test build #81202 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81202/testReport)** for PR 19064 at commit

[GitHub] spark issue #19064: [SPARK-21848][SQL] Add trait UDFType to identify user-de...

2017-08-29 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/19064 It is better to review PR title and description to reflect the change from `UDFType` to `UserDefinedExpression`. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark issue #19064: [SPARK-21848][SQL] Add trait UDFType to identify user-de...

2017-08-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19064 **[Test build #81202 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81202/testReport)** for PR 19064 at commit

[GitHub] spark issue #19064: [SPARK-21848][SQL] Add trait UDFType to identify user-de...

2017-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19064 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81192/ Test PASSed. ---

[GitHub] spark issue #19064: [SPARK-21848][SQL] Add trait UDFType to identify user-de...

2017-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19064 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #19064: [SPARK-21848][SQL] Add trait UDFType to identify user-de...

2017-08-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19064 **[Test build #81192 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81192/testReport)** for PR 19064 at commit

[GitHub] spark issue #19064: [SPARK-21848][SQL] Add trait UDFType to identify user-de...

2017-08-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19064 **[Test build #81192 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81192/testReport)** for PR 19064 at commit

[GitHub] spark issue #19064: [SPARK-21848][SQL] Add trait UDFType to identify user-de...

2017-08-28 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/19064 I'm +1 on this, it should be useful to pattern match the trait instead of handling ScalaUDF/ScalaUDAF/PythonUDF... in future optimize rules. --- If your project is set up for it, you can reply

[GitHub] spark issue #19064: [SPARK-21848][SQL] Add trait UDFType to identify user-de...

2017-08-28 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/19064 I'm +1 on this, currently we are pattern matching `ScalaUDF` in optimize rules which is suboptional. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark issue #19064: [SPARK-21848][SQL] Add trait UDFType to identify user-de...

2017-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19064 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #19064: [SPARK-21848][SQL] Add trait UDFType to identify user-de...

2017-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19064 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81177/ Test PASSed. ---

[GitHub] spark issue #19064: [SPARK-21848][SQL] Add trait UDFType to identify user-de...

2017-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19064 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81174/ Test PASSed. ---

[GitHub] spark issue #19064: [SPARK-21848][SQL] Add trait UDFType to identify user-de...

2017-08-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19064 **[Test build #81177 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81177/testReport)** for PR 19064 at commit

[GitHub] spark issue #19064: [SPARK-21848][SQL] Add trait UDFType to identify user-de...

2017-08-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19064 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #19064: [SPARK-21848][SQL] Add trait UDFType to identify user-de...

2017-08-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19064 **[Test build #81174 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81174/testReport)** for PR 19064 at commit

[GitHub] spark issue #19064: [SPARK-21848][SQL] Add trait UDFType to identify user-de...

2017-08-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19064 **[Test build #81177 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81177/testReport)** for PR 19064 at commit

[GitHub] spark issue #19064: [SPARK-21848][SQL] Add trait UDFType to identify user-de...

2017-08-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19064 **[Test build #81174 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81174/testReport)** for PR 19064 at commit

[GitHub] spark issue #19064: [SPARK-21848][SQL] Add trait UDFType to identify user-de...

2017-08-28 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19064 Yes. This is a potential optimization we should do, but it should be cost based. Let us improve the resolution logics using this common base trait in this PR first. --- If your project is set