[GitHub] spark issue #19143: [SPARK-21932][SQL]Remove package name similar 'logical.J...

2017-09-06 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/19143 okay, do you mean I need to change the title? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #19143: [SPARK-21932][SQL]Remove package name similar 'logical.J...

2017-09-06 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19143 You haven't actually added tests, and that's not all this PR does. At the least, this doesn't match the intent you describe, and should be closed. I'd back up and describe the test you want in the

[GitHub] spark issue #19143: [SPARK-21932][SQL]Remove package name similar 'logical.J...

2017-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19143 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19143: [SPARK-21932][SQL]Remove package name similar 'logical.J...

2017-09-06 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/19143 @srowen Actually, I think this one makes sense. Because the two open test cases are tested, we connect the Cartesian product and the broadcast nested loop join. When we understand the two

[GitHub] spark issue #19143: [SPARK-21932][SQL]Remove package name similar 'logical.J...

2017-09-06 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/19143 Leave a comment --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19143: [SPARK-21932][SQL]Remove package name similar 'logical.J...

2017-09-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19143 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional