Github user dbtsai commented on the issue:
https://github.com/apache/spark/pull/19381
@WeichenXu123 we were discussing this when we moved out common math code
into `mllib-local`, but there is no umbrella ticket around it. I talked to many
companies, and that is one of the pain point
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/19381
@dbtsai Good idea! Is there a related JIRA or could you open one for it ?
cc @jkbradley
---
-
To unsubscribe, e-mail:
Github user dbtsai commented on the issue:
https://github.com/apache/spark/pull/19381
Too late to the party! Great PR. We should also think about refactor the
predictors to `mllib-local` eventually so people can use them in prod without
depending on Spark.
---
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/19381
Merging with master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19381
**[Test build #88446 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88446/testReport)**
for PR 19381 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19381
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88446/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19381
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19381
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19381
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1662/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19381
**[Test build #88446 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88446/testReport)**
for PR 19381 at commit
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/19381
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19381
**[Test build #4142 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4142/testReport)**
for PR 19381 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19381
**[Test build #4142 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4142/testReport)**
for PR 19381 at commit
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/19381
LGTM
Merging after fresh tests run
Thanks a lot @WeichenXu123 for the PR and others for reviews!
---
-
To unsubscribe,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19381
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88288/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19381
**[Test build #88288 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88288/testReport)**
for PR 19381 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19381
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19381
**[Test build #88288 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88288/testReport)**
for PR 19381 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19381
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1547/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19381
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19381
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88179/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19381
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19381
**[Test build #88179 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88179/testReport)**
for PR 19381 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19381
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1467/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19381
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19381
**[Test build #88179 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88179/testReport)**
for PR 19381 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19381
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19381
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88175/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19381
**[Test build #88175 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88175/testReport)**
for PR 19381 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19381
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19381
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1464/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19381
**[Test build #88175 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88175/testReport)**
for PR 19381 at commit
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/19381
Thanks for the PR!
Can you please add Since annotations?
Also, can the test code be consolidated? Maybe you can have a helper
function taking a model and dataset, usable with all
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19381
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88000/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19381
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19381
**[Test build #88000 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88000/testReport)**
for PR 19381 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19381
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1313/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19381
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19381
**[Test build #88000 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88000/testReport)**
for PR 19381 at commit
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/19381
Jenkins, test this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19381
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87990/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19381
Build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19381
**[Test build #87990 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87990/testReport)**
for PR 19381 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19381
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19381
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87991/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19381
**[Test build #87991 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87991/testReport)**
for PR 19381 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19381
**[Test build #87991 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87991/testReport)**
for PR 19381 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19381
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19381
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1304/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19381
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1303/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19381
**[Test build #87990 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87990/testReport)**
for PR 19381 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19381
Build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19381
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19381
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87693/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19381
**[Test build #87693 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87693/testReport)**
for PR 19381 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19381
**[Test build #87693 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87693/testReport)**
for PR 19381 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19381
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1081/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19381
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/19381
Jenkins, test this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19381
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19381
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84654/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19381
**[Test build #84654 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84654/testReport)**
for PR 19381 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19381
**[Test build #84654 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84654/testReport)**
for PR 19381 at commit
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/19381
I'll try to take a look but am pretty swamped currently. CC @yanboliang
@MLnick @dbtsai @holdenk might you have time?
---
-
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19381
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83877/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19381
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19381
**[Test build #83877 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83877/testReport)**
for PR 19381 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19381
**[Test build #83877 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83877/testReport)**
for PR 19381 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19381
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19381
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83398/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19381
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83394/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19381
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19381
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83328/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19381
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user smurching commented on the issue:
https://github.com/apache/spark/pull/19381
Looking at this now!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/19381
cc @jkbradley @yanboliang thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user drod331 commented on the issue:
https://github.com/apache/spark/pull/19381
@WeichenXu123 My team and I are looking forward to the flexibility and
efficiency provided by these changes. What can I do to help get these changes
merged into Spark master? Thanks for your
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19381
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82277/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19381
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19381
**[Test build #82277 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82277/testReport)**
for PR 19381 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19381
**[Test build #82277 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82277/testReport)**
for PR 19381 at commit
81 matches
Mail list logo
