Github user rdblue commented on the issue:
https://github.com/apache/spark/pull/19568
@gatorsmile, I think it would be better to fix codegen than to prevent it
from happening with an assertion. If `CodegenFallback` can produce fallback
code, why not allow it to when necessary?
---
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19568
@rdblue Yes, the current implementation implicitly assumes the rule
`CollapseCodegenStages ` excludes all the illegal cases. How about adding an
`assert` to do the check that the condition of
Github user rdblue commented on the issue:
https://github.com/apache/spark/pull/19568
@DonnyZone, I don't know of any cases that use codgen after the fix for
`CodegenFallback`, but I think this is still a good idea.
If Spark is going to generate code, it should generate
Github user DonnyZone commented on the issue:
https://github.com/apache/spark/pull/19568
@rdblue Could you find any cases that can trigger the problem of wrong
INPUT_ROW in SortMergeJoinExec after the fix
(https://github.com/apache/spark/pull/18656) for CollapseCodegenStages rule? I
Github user DonnyZone commented on the issue:
https://github.com/apache/spark/pull/19568
This PR is similar to the initial commit when I try to fix SPARK-21441 in
https://github.com/apache/spark/pull/18656
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19568
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83090/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19568
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19568
**[Test build #83090 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83090/testReport)**
for PR 19568 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19568
**[Test build #83090 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83090/testReport)**
for PR 19568 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19568
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19568
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83056/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19568
**[Test build #83056 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83056/testReport)**
for PR 19568 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19568
**[Test build #83056 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83056/testReport)**
for PR 19568 at commit
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/19568
Could you please change title from `SPARK-22345` to `[SPARK-22345]`?
---
-
To unsubscribe, e-mail:
Github user rdblue commented on the issue:
https://github.com/apache/spark/pull/19568
@dongjoon-hyun, yes, I'm currently working on it. I just wanted to get the
rest up.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19568
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19568
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83023/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19568
**[Test build #83023 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83023/testReport)**
for PR 19568 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19568
**[Test build #83023 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83023/testReport)**
for PR 19568 at commit
19 matches
Mail list logo
