Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19638
Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19638
**[Test build #3987 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3987/testReport)**
for PR 19638 at commit
[`68e467e`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19638
**[Test build #3987 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3987/testReport)**
for PR 19638 at commit
[`68e467e`](https://github.com/apache/spark/commit/6
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19638
Ignore it, it's due to an unrelated external problem with the
repo1.maven.org domain, I'm pretty sure. I'm about to push a fix.
---
-
Github user tengpeng commented on the issue:
https://github.com/apache/spark/pull/19638
Not sure what's happening here. The test on my local machine passed:
Running Apache RAT checks
==
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19638
**[Test build #3986 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3986/testReport)**
for PR 19638 at commit
[`68e467e`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19638
**[Test build #3986 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3986/testReport)**
for PR 19638 at commit
[`68e467e`](https://github.com/apache/spark/commit/6
Github user tengpeng commented on the issue:
https://github.com/apache/spark/pull/19638
I have used @sethah 's approach to address the issues we have. Since we are
not adding a new method to the public trait, there is no more binary
compatibility issue.
---
-
Github user MLnick commented on the issue:
https://github.com/apache/spark/pull/19638
Do we need to expose it publicly in the trait? Could we make it
`private[mllib]`? Since it will only be used to compute this metric.
Alternatively, you can just compute `n` from the size of o
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19638
Hm, right, this fails because it's adding a method to a public trait.
Although it's unlikely anyone implements this, they might. Hm, not sure what we
do here that can preserve source and binary compa
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19638
**[Test build #3977 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3977/testReport)**
for PR 19638 at commit
[`180b2d6`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19638
**[Test build #3977 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3977/testReport)**
for PR 19638 at commit
[`180b2d6`](https://github.com/apache/spark/commit/1
Github user tengpeng commented on the issue:
https://github.com/apache/spark/pull/19638
@srowen I have fixed scaladocs and since issues. I will pay special
attention to this issue next time.
---
-
To unsubscribe, e-
Github user tengpeng commented on the issue:
https://github.com/apache/spark/pull/19638
Would it be possible to add me to the white list for test? Thanks.
On Thu, Nov 2, 2017 at 12:17 AM UCB AMPLab wrote:
> Can one of the admins verify this patch?
>
> â
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19638
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
15 matches
Mail list logo
