[GitHub] spark issue #19821: [WIP][SPARK-22608][SQL] add new API to CodeGeneration.sp...

2017-11-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19821 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19821: [WIP][SPARK-22608][SQL] add new API to CodeGeneration.sp...

2017-11-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19821 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84293/ Test PASSed. ---

[GitHub] spark issue #19821: [WIP][SPARK-22608][SQL] add new API to CodeGeneration.sp...

2017-11-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19821 **[Test build #84293 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84293/testReport)** for PR 19821 at commit

[GitHub] spark issue #19821: [WIP][SPARK-22608][SQL] add new API to CodeGeneration.sp...

2017-11-29 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19821 LGTM, can you remove `WIP` in PR title? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19821: [WIP][SPARK-22608][SQL] add new API to CodeGeneration.sp...

2017-11-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19821 **[Test build #84293 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84293/testReport)** for PR 19821 at commit

[GitHub] spark issue #19821: [WIP][SPARK-22608][SQL] add new API to CodeGeneration.sp...

2017-11-28 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/19821 Sure, I have resolved the conflict in my environment. I will commit soon. --- - To unsubscribe, e-mail:

[GitHub] spark issue #19821: [WIP][SPARK-22608][SQL] add new API to CodeGeneration.sp...

2017-11-28 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19821 @kiszk Can you fix the conflict? now we can add a middle-advanced version: ``` def splitExpressions( expressions: Seq[String], funcName: String, extraArguments:

[GitHub] spark issue #19821: [WIP][SPARK-22608][SQL] add new API to CodeGeneration.sp...

2017-11-27 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/19821 I have no strong preference. @gatorsmile WDYT? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #19821: [WIP][SPARK-22608][SQL] add new API to CodeGeneration.sp...

2017-11-27 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19821 is it really worth? seems not used in many places and eventually the if-else will be removed after we make `splitExpression` work with whole stage codegen ---

[GitHub] spark issue #19821: [WIP][SPARK-22608][SQL] add new API to CodeGeneration.sp...

2017-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19821 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19821: [WIP][SPARK-22608][SQL] add new API to CodeGeneration.sp...

2017-11-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19821 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84191/ Test PASSed. ---

[GitHub] spark issue #19821: [WIP][SPARK-22608][SQL] add new API to CodeGeneration.sp...

2017-11-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19821 **[Test build #84191 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84191/testReport)** for PR 19821 at commit

[GitHub] spark issue #19821: [WIP][SPARK-22608][SQL] add new API to CodeGeneration.sp...

2017-11-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19821 **[Test build #84191 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84191/testReport)** for PR 19821 at commit