Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/19843
LGTM, but I'll wait for the PR title & description updates to merge this.
Thanks!
---
-
To unsubscribe, e-mail:
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/19843
Also, can you please remove "WIP" from the PR title and update the Testing
part of the PR description?
---
-
To unsubscribe,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19843
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19843
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84637/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19843
**[Test build #84637 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84637/testReport)**
for PR 19843 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19843
**[Test build #84637 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84637/testReport)**
for PR 19843 at commit
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/19843
I'll make a call: Given that the SQL tests do not use clearActive, let's
not bother with it. If we see flakiness, then we can try adding clearActive as
a fix.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19843
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84600/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19843
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19843
**[Test build #84600 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84600/testReport)**
for PR 19843 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19843
**[Test build #84600 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84600/testReport)**
for PR 19843 at commit
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/19843
add UT for MLTest and change to use PipelineModel.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/19843
This looks awesome; I just had a couple of comments. Btw, this is fancy
test code. It might be nice to add a little unit test to MLTest.scala to make
sure that testTransformer does indeed fail
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19843
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84328/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19843
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19843
**[Test build #84328 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84328/testReport)**
for PR 19843 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19843
**[Test build #84328 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84328/testReport)**
for PR 19843 at commit
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/19843
@MrBago Thanks!
I update code, now new action class `CheckAnswerRowsByFunc` is added. I do
not add common trait as both of them are simple and I don't want to break old
code.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19843
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19843
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84290/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19843
**[Test build #84290 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84290/testReport)**
for PR 19843 at commit
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/19843
@MrBago @jkbradley
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19843
**[Test build #84290 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84290/testReport)**
for PR 19843 at commit
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/19843
Jenkins retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19843
**[Test build #84286 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84286/testReport)**
for PR 19843 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19843
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19843
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84286/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19843
**[Test build #84287 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84287/testReport)**
for PR 19843 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19843
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84287/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19843
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19843
**[Test build #84287 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84287/testReport)**
for PR 19843 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19843
**[Test build #84286 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84286/testReport)**
for PR 19843 at commit
32 matches
Mail list logo
