Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20024
Thanks! I'll do.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20024
as a follow-up, we should do the same thing for struct and map type too.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spar
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20024
thanks, merging to master/2.3!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-ma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20024
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20024
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85714/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20024
**[Test build #85714 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85714/testReport)**
for PR 20024 at commit
[`dc15b93`](https://github.com/apache/spark/commit/d
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20024
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85710/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20024
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20024
**[Test build #85710 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85710/testReport)**
for PR 20024 at commit
[`449e2c9`](https://github.com/apache/spark/commit/4
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20024
**[Test build #85714 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85714/testReport)**
for PR 20024 at commit
[`dc15b93`](https://github.com/apache/spark/commit/dc
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20024
**[Test build #85710 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85710/testReport)**
for PR 20024 at commit
[`449e2c9`](https://github.com/apache/spark/commit/44
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20024
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h..
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20024
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85701/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20024
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20024
**[Test build #85701 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85701/testReport)**
for PR 20024 at commit
[`449e2c9`](https://github.com/apache/spark/commit/4
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20024
**[Test build #85701 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85701/testReport)**
for PR 20024 at commit
[`449e2c9`](https://github.com/apache/spark/commit/44
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20024
Thanks for the kindly checks in the year start and all the comments done.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20024
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85681/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20024
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20024
**[Test build #85681 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85681/testReport)**
for PR 20024 at commit
[`09fd22e`](https://github.com/apache/spark/commit/0
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20024
LGTM except a few minor comments
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20024
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85676/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20024
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20024
**[Test build #85676 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85676/testReport)**
for PR 20024 at commit
[`b0b3cd6`](https://github.com/apache/spark/commit/b
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20024
**[Test build #85681 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85681/testReport)**
for PR 20024 at commit
[`09fd22e`](https://github.com/apache/spark/commit/09
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20024
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85671/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20024
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20024
**[Test build #85671 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85671/testReport)**
for PR 20024 at commit
[`b5b5e35`](https://github.com/apache/spark/commit/b
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20024
**[Test build #85676 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85676/testReport)**
for PR 20024 at commit
[`b0b3cd6`](https://github.com/apache/spark/commit/b0
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20024
**[Test build #85671 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85671/testReport)**
for PR 20024 at commit
[`b5b5e35`](https://github.com/apache/spark/commit/b5
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20024
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85660/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20024
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20024
**[Test build #85660 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85660/testReport)**
for PR 20024 at commit
[`1d623f8`](https://github.com/apache/spark/commit/1
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20024
**[Test build #85660 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85660/testReport)**
for PR 20024 at commit
[`1d623f8`](https://github.com/apache/spark/commit/1d
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20024
ok, all the comments addressed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20024
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20024
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85652/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20024
**[Test build #85652 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85652/testReport)**
for PR 20024 at commit
[`a46a9a7`](https://github.com/apache/spark/commit/a
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20024
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20024
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85649/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20024
**[Test build #85649 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85649/testReport)**
for PR 20024 at commit
[`c2e6757`](https://github.com/apache/spark/commit/c
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20024
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85650/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20024
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20024
**[Test build #85650 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85650/testReport)**
for PR 20024 at commit
[`8705f84`](https://github.com/apache/spark/commit/8
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20024
**[Test build #85652 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85652/testReport)**
for PR 20024 at commit
[`a46a9a7`](https://github.com/apache/spark/commit/a4
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20024
**[Test build #85650 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85650/testReport)**
for PR 20024 at commit
[`8705f84`](https://github.com/apache/spark/commit/87
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20024
**[Test build #85649 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85649/testReport)**
for PR 20024 at commit
[`c2e6757`](https://github.com/apache/spark/commit/c2
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20024
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85640/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20024
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20024
**[Test build #85640 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85640/testReport)**
for PR 20024 at commit
[`9e13bb9`](https://github.com/apache/spark/commit/9
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20024
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20024
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85634/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20024
**[Test build #85634 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85634/testReport)**
for PR 20024 at commit
[`91a60c3`](https://github.com/apache/spark/commit/9
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20024
**[Test build #85640 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85640/testReport)**
for PR 20024 at commit
[`9e13bb9`](https://github.com/apache/spark/commit/9e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20024
**[Test build #85634 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85634/testReport)**
for PR 20024 at commit
[`91a60c3`](https://github.com/apache/spark/commit/91
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20024
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85633/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20024
**[Test build #85633 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85633/testReport)**
for PR 20024 at commit
[`570f13b`](https://github.com/apache/spark/commit/5
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20024
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20024
**[Test build #85633 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85633/testReport)**
for PR 20024 at commit
[`570f13b`](https://github.com/apache/spark/commit/57
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20024
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20024
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85632/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20024
**[Test build #85632 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85632/testReport)**
for PR 20024 at commit
[`e77ea6b`](https://github.com/apache/spark/commit/e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20024
**[Test build #85632 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85632/testReport)**
for PR 20024 at commit
[`e77ea6b`](https://github.com/apache/spark/commit/e7
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20024
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20024
**[Test build #85631 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85631/testReport)**
for PR 20024 at commit
[`d7cf391`](https://github.com/apache/spark/commit/d
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20024
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85631/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20024
**[Test build #85630 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85630/testReport)**
for PR 20024 at commit
[`edd5abf`](https://github.com/apache/spark/commit/e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20024
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20024
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85630/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20024
**[Test build #85631 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85631/testReport)**
for PR 20024 at commit
[`d7cf391`](https://github.com/apache/spark/commit/d7
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20024
@cloud-fan How about the current impl.? (not finished yet though)
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.o
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20024
**[Test build #85630 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85630/testReport)**
for PR 20024 at commit
[`edd5abf`](https://github.com/apache/spark/commit/ed
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20024
ok, I'll brush up based on your suggestion.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comm
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20024
I feel it's not the most effcient way to cast array to string by
deserializing the catalyst array to java array. Instead, I think we should have
a schema-aware string casting function, i.e. using
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20024
cc @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h..
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20024
ping
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20024
could you check, thanks! cc: @gatorsmile @viirya
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additiona
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20024
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85119/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20024
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20024
**[Test build #85119 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85119/testReport)**
for PR 20024 at commit
[`211e7f3`](https://github.com/apache/spark/commit/2
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20024
`MapType` has the same issue;
```
scala> Seq(Map(1 -> "a", 2 -> "b")).toDF("a").write.saveAsTable("t")
scala> sql("SELECT cast(a as String) FROM t").show(false)
+---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20024
**[Test build #85119 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85119/testReport)**
for PR 20024 at commit
[`211e7f3`](https://github.com/apache/spark/commit/21
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20024
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85118/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20024
**[Test build #85118 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85118/testReport)**
for PR 20024 at commit
[`ed7f885`](https://github.com/apache/spark/commit/e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20024
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20024
**[Test build #85118 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85118/testReport)**
for PR 20024 at commit
[`ed7f885`](https://github.com/apache/spark/commit/ed
86 matches
Mail list logo
