[GitHub] spark issue #20070: SPARK-22896 Improvement in String interpolation

2018-01-03 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/20070 Merged to master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20070: SPARK-22896 Improvement in String interpolation

2018-01-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20070 **[Test build #4033 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4033/testReport)** for PR 20070 at commit

[GitHub] spark issue #20070: SPARK-22896 Improvement in String interpolation

2018-01-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20070 **[Test build #4033 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4033/testReport)** for PR 20070 at commit

[GitHub] spark issue #20070: SPARK-22896 Improvement in String interpolation

2018-01-03 Thread chetkhatri
Github user chetkhatri commented on the issue: https://github.com/apache/spark/pull/20070 @srowen Request for review when you get on this. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #20070: SPARK-22896 Improvement in String interpolation

2017-12-30 Thread chetkhatri
Github user chetkhatri commented on the issue: https://github.com/apache/spark/pull/20070 @srowen Okey. current status looks good --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20070: SPARK-22896 Improvement in String interpolation

2017-12-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20070 **[Test build #4031 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4031/testReport)** for PR 20070 at commit

[GitHub] spark issue #20070: SPARK-22896 Improvement in String interpolation

2017-12-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20070 **[Test build #4031 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4031/testReport)** for PR 20070 at commit

[GitHub] spark issue #20070: SPARK-22896 Improvement in String interpolation

2017-12-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20070 **[Test build #4029 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4029/testReport)** for PR 20070 at commit

[GitHub] spark issue #20070: SPARK-22896 Improvement in String interpolation

2017-12-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20070 **[Test build #4029 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4029/testReport)** for PR 20070 at commit

[GitHub] spark issue #20070: SPARK-22896 Improvement in String interpolation

2017-12-28 Thread chetkhatri
Github user chetkhatri commented on the issue: https://github.com/apache/spark/pull/20070 @srowen please do re-run the build. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20070: SPARK-22896 Improvement in String interpolation

2017-12-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20070 **[Test build #4028 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4028/testReport)** for PR 20070 at commit

[GitHub] spark issue #20070: SPARK-22896 Improvement in String interpolation

2017-12-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20070 **[Test build #4028 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4028/testReport)** for PR 20070 at commit

[GitHub] spark issue #20070: SPARK-22896 Improvement in String interpolation

2017-12-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20070 **[Test build #4026 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4026/testReport)** for PR 20070 at commit

[GitHub] spark issue #20070: SPARK-22896 Improvement in String interpolation

2017-12-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20070 **[Test build #4026 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4026/testReport)** for PR 20070 at commit

[GitHub] spark issue #20070: SPARK-22896 Improvement in String interpolation

2017-12-26 Thread chetkhatri
Github user chetkhatri commented on the issue: https://github.com/apache/spark/pull/20070 @srowen I rechecked all scala examples and this is commulative PR for the same. --- - To unsubscribe, e-mail:

[GitHub] spark issue #20070: SPARK-22896 Improvement in String interpolation

2017-12-26 Thread chetkhatri
Github user chetkhatri commented on the issue: https://github.com/apache/spark/pull/20070 You're correct - I missed other packages. I will re-confirm soon. Thanks. --- - To unsubscribe, e-mail:

[GitHub] spark issue #20070: SPARK-22896 Improvement in String interpolation

2017-12-26 Thread chetkhatri
Github user chetkhatri commented on the issue: https://github.com/apache/spark/pull/20070 In scala ? I don't think so. I am re-iterating and doing double check. --- - To unsubscribe, e-mail:

[GitHub] spark issue #20070: SPARK-22896 Improvement in String interpolation

2017-12-26 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/20070 I think there are many more examples of this; a quick search suggests there are about 40 example files that have some string concatenation. ---

[GitHub] spark issue #20070: SPARK-22896 Improvement in String interpolation

2017-12-26 Thread chetkhatri
Github user chetkhatri commented on the issue: https://github.com/apache/spark/pull/20070 @srowen also i did merge another similiar PR with graphx to here. so Just FYI - we are good. --- - To unsubscribe, e-mail:

[GitHub] spark issue #20070: SPARK-22896 Improvement in String interpolation

2017-12-26 Thread chetkhatri
Github user chetkhatri commented on the issue: https://github.com/apache/spark/pull/20070 @srowen Absolutely correct, this all in one shot. I did changes in all. --- - To unsubscribe, e-mail:

[GitHub] spark issue #20070: SPARK-22896 Improvement in String interpolation

2017-12-26 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/20070 OK, we can do this for consistency. In general we don't spend a ton of time on changes like this, because there is already way too much else to review. Please make one change only (this one) that

[GitHub] spark issue #20070: SPARK-22896 Improvement in String interpolation

2017-12-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20070 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional