Github user squito commented on the issue:
https://github.com/apache/spark/pull/20138
as RC1 failed and RC2 is going to be cut soon, I'm going to merge this to
master & 2.3
---
-
To unsubscribe, e-mail:
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/20138
LGTM and it looks safe.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/20138
This PR introduces an more thoughtful event logs cleanup method, if users
have `spark.history.fs.cleaner.enabled` set to true, their existing invalid
event log files(empty/no valid
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20138
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86199/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20138
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20138
**[Test build #86199 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86199/testReport)**
for PR 20138 at commit
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/20138
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user squito commented on the issue:
https://github.com/apache/spark/pull/20138
lgtm
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20138
**[Test build #86199 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86199/testReport)**
for PR 20138 at commit
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/20138
I was actually suggesting have the "aggressive" option default turned on,
and I'm also fine to not have that config at all. Will take a closer look at
this later, thanks you for ping me @squito
Github user ajbozarth commented on the issue:
https://github.com/apache/spark/pull/20138
Ok, no problems here on that front then. If I have time later to do a
proper review and this has't been merged yet I'll take better a look at the
whole PR
---
Github user squito commented on the issue:
https://github.com/apache/spark/pull/20138
well, perhaps I mis-represented this -- you still need to turn the event
log cleaning on explicitly with the old option,
"spark.history.fs.cleaner.enabled". This just doesn't include the
Github user ajbozarth commented on the issue:
https://github.com/apache/spark/pull/20138
I haven't had a chance to read though your code, but as @squito said, I am
against any default feature that deletes files from the eventLog dir. Many
users, such as myself, use one log dir for
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20138
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85686/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20138
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20138
**[Test build #85686 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85686/testReport)**
for PR 20138 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20138
**[Test build #85686 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85686/testReport)**
for PR 20138 at commit
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20138
@squito
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20138
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85611/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20138
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20138
**[Test build #85611 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85611/testReport)**
for PR 20138 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20138
**[Test build #85611 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85611/testReport)**
for PR 20138 at commit
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20138
There are some previous comments on this code at:
https://github.com/vanzin/spark/pull/40
---
-
To unsubscribe, e-mail:
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20138
@ericvandenbergfb
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
24 matches
Mail list logo
