[GitHub] spark issue #20158: [PySpark] Fix typo in comments in PySpark's udf() defini...

2018-01-17 Thread rednaxelafx
Github user rednaxelafx commented on the issue: https://github.com/apache/spark/pull/20158 @HyukjinKwon cool! Thanks a lot for including it! Closing this one now. --- - To unsubscribe, e-mail: reviews-unsubscr...@spa

[GitHub] spark issue #20158: [PySpark] Fix typo in comments in PySpark's udf() defini...

2018-01-16 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20158 @rednaxelafx, I was fixing some codes around UDF. I included the current typo in https://github.com/apache/spark/pull/20288. I think you could close this one. ---

[GitHub] spark issue #20158: [PySpark] Fix typo in comments in PySpark's udf() defini...

2018-01-11 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20158 @rednaxelafx, can you fix the one in `pandas_udf` too? I'll just merge this. --- - To unsubscribe, e-mail: reviews-unsubscr..

[GitHub] spark issue #20158: [PySpark] Fix typo in comments in PySpark's udf() defini...

2018-01-09 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/20158 Ping @rednaxelafx --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h..

[GitHub] spark issue #20158: [PySpark] Fix typo in comments in PySpark's udf() defini...

2018-01-08 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20158 let's get them fixed for 2.3? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-m

[GitHub] spark issue #20158: [PySpark] Fix typo in comments in PySpark's udf() defini...

2018-01-07 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20158 There's a same typo in `pandas_udf` too BTW. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additiona

[GitHub] spark issue #20158: [PySpark] Fix typo in comments in PySpark's udf() defini...

2018-01-04 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/20158 You can just combine small-scale fixes to the surrounding code in the main PR then. I think that's fine. --- - To unsubscribe, e-

[GitHub] spark issue #20158: [PySpark] Fix typo in comments in PySpark's udf() defini...

2018-01-04 Thread rednaxelafx
Github user rednaxelafx commented on the issue: https://github.com/apache/spark/pull/20158 @srowen Thanks for your review! I'll have a look at other typos and update this PR later. I was actually working on code around this place and thought I'd split out the typo fix to make

[GitHub] spark issue #20158: [PySpark] Fix typo in comments in PySpark's udf() defini...

2018-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20158 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85700/ Test PASSed. ---

[GitHub] spark issue #20158: [PySpark] Fix typo in comments in PySpark's udf() defini...

2018-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20158 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20158: [PySpark] Fix typo in comments in PySpark's udf() defini...

2018-01-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20158 **[Test build #85700 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85700/testReport)** for PR 20158 at commit [`1d42d86`](https://github.com/apache/spark/commit/1

[GitHub] spark issue #20158: [PySpark] Fix typo in comments in PySpark's udf() defini...

2018-01-04 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/20158 OK. Have a look for more typos while you're at it. We try to avoid whole PRs just to fix each one. --- - To unsubscribe, e-mail:

[GitHub] spark issue #20158: [PySpark] Fix typo in comments in PySpark's udf() defini...

2018-01-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20158 **[Test build #85700 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85700/testReport)** for PR 20158 at commit [`1d42d86`](https://github.com/apache/spark/commit/1d