[GitHub] spark issue #20323: [BUILD][MINOR] Fix java style check issues

2018-01-19 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/20323 The only downside is spreading the CI here across many different systems. I know we add Appveyor because it was the only way to test on Windows (right?). Adding Travis too just for Java style checks

[GitHub] spark issue #20323: [BUILD][MINOR] Fix java style check issues

2018-01-19 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/20323 I'm wondering why we are okay for AppVoyer and not okay for Travis CI. :) --- - To unsubscribe, e-mail:

[GitHub] spark issue #20323: [BUILD][MINOR] Fix java style check issues

2018-01-19 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/20323 @HyukjinKwon . Travis CI will trigger at every commit. What I mean is our script can check the Java changes only. @sameeragarwal . Travis CI is independently running on Travis CI site

[GitHub] spark issue #20323: [BUILD][MINOR] Fix java style check issues

2018-01-19 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/20323 merging this to master/2.3. Thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20323: [BUILD][MINOR] Fix java style check issues

2018-01-19 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/20323 @dongjoon-hyun while I'm not opposed to adding another builder, my concern is that it's hard to justify spending 30+ mins for a simple java style check for every pull request (i.e., if we run

[GitHub] spark issue #20323: [BUILD][MINOR] Fix java style check issues

2018-01-18 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20323 > If Travis CI can not handle the full traffic of Apache Spark PRs, we may run it for only Java code change PRs. @dongjoon-hyun, do you know if Travis CI supports exclusion/inclusion of

[GitHub] spark issue #20323: [BUILD][MINOR] Fix java style check issues

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20323 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86363/ Test PASSed. ---

[GitHub] spark issue #20323: [BUILD][MINOR] Fix java style check issues

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20323 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20323: [BUILD][MINOR] Fix java style check issues

2018-01-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20323 **[Test build #86363 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86363/testReport)** for PR 20323 at commit

[GitHub] spark issue #20323: [BUILD][MINOR] Fix java style check issues

2018-01-18 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/20323 @sameeragarwal . Can we turn on Travis CI for that purpose like AppVeyor? I made it already in Apache Spark, but it's not enabled because there is a concern about Travis CI capacity. ---

[GitHub] spark issue #20323: [BUILD][MINOR] Fix java style check issues

2018-01-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20323 **[Test build #86363 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86363/testReport)** for PR 20323 at commit

[GitHub] spark issue #20323: [BUILD][MINOR] Fix java style check issues

2018-01-18 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/20323 I keep forgetting why we can't turn on the checks -- was it just a time thing, because it meant a whole other pass over the code with maven? ---

[GitHub] spark issue #20323: [BUILD][MINOR] Fix java style check issues

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20323 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20323: [BUILD][MINOR] Fix java style check issues

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20323 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/18/ Test