Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20415
thanks, merging to master!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20415
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20415
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86898/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20415
**[Test build #86898 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86898/testReport)**
for PR 20415 at commit
Github user heary-cao commented on the issue:
https://github.com/apache/spark/pull/20415
@mgaido91 thanks.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20415
**[Test build #86898 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86898/testReport)**
for PR 20415 at commit
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/20415
LGTM, only a minor comment
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20415
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20415
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86860/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20415
**[Test build #86860 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86860/testReport)**
for PR 20415 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20415
**[Test build #86860 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86860/testReport)**
for PR 20415 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20415
looks like a reasonable change to me. Although I don't think this will have
some significant performance improvement, it makes the code more compact.
---
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20415
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user heary-cao commented on the issue:
https://github.com/apache/spark/pull/20415
@cloud-fan Can you help me to review it. thanks.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user heary-cao commented on the issue:
https://github.com/apache/spark/pull/20415
@hvanhovell ,thank you for review it.
I tested the code for this PR change,
**in FileSourceScanExec->doExecute code:**
```
if (needsUnsafeRowConversion) {
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20415
@heary-cao have you benchmarked this? The reason I am asking is because
Spark SQL chains iterators, these are pipelined and only materialized when we
need to. Your PR effectively removes two
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20415
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20415
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
18 matches
Mail list logo
