[GitHub] spark issue #20458: changed scala example from java "style" to scala

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20458 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20458: changed scala example from java "style" to scala

Github user mantovani commented on the issue: https://github.com/apache/spark/pull/20458 Sean, I already tested. Can you please be more specific how should be the tests ? I just tested on Spark 2.1.1 and Scala 2.11 and 2.10. On Wed, Jan 31, 2018 at 19:19 Sean Owen

[GitHub] spark issue #20458: changed scala example from java "style" to scala

Github user srowen commented on the issue: https://github.com/apache/spark/pull/20458 The point is that it won't always work in Spark, so, certainly not unless you test them. I just don't think it's worth it, especially as it's setting an expectation as an example that it is the best

[GitHub] spark issue #20458: changed scala example from java "style" to scala

Github user mantovani commented on the issue: https://github.com/apache/spark/pull/20458 If I change all examples of the documentation will be accept ? On Wed, Jan 31, 2018 at 6:41 PM, Sean Owen wrote: > Yeah, that's what I was thinking of.

[GitHub] spark issue #20458: changed scala example from java "style" to scala

Github user srowen commented on the issue: https://github.com/apache/spark/pull/20458 Yeah, that's what I was thinking of. Subclasses of `App` don't necessarily work in Spark (not just Scala). I don't know if that has changed as Spark and Scala moved forward. While that's an

[GitHub] spark issue #20458: changed scala example from java "style" to scala

Github user mantovani commented on the issue: https://github.com/apache/spark/pull/20458 I just tested with Scala 2.10.6 and worked perfect. 18/01/31 17:21:28 INFO DAGScheduler: Job 1 finished: count at Bootstrap.scala:14, took 0.024446 s DemoBug: rslt1 = 3 rslt2 = 3

[GitHub] spark issue #20458: changed scala example from java "style" to scala

Github user vanzin commented on the issue: https://github.com/apache/spark/pull/20458 Did you try it with Scala 2.10? That's still supported by Spark. --- - To unsubscribe, e-mail:

[GitHub] spark issue #20458: changed scala example from java "style" to scala

Github user mantovani commented on the issue: https://github.com/apache/spark/pull/20458 Hello Marcel, This is an old bug and was fixed long time ago, I just runned the following example and got the correct result: DemoBug: rslt1 = 3 rslt2 = 3 Doesn't make

[GitHub] spark issue #20458: changed scala example from java "style" to scala

Github user vanzin commented on the issue: https://github.com/apache/spark/pull/20458 > It's not just "will" work, it's working. https://issues.apache.org/jira/browse/SPARK-4170 --- - To unsubscribe,

[GitHub] spark issue #20458: changed scala example from java "style" to scala

Github user mantovani commented on the issue: https://github.com/apache/spark/pull/20458 It's not just "will" work, _it's working_. I never said that it wasn't working, the Scala example was wrote using Java "style" not Scala "style" which . Which you don't create a main method but

[GitHub] spark issue #20458: changed scala example from java "style" to scala

Github user srowen commented on the issue: https://github.com/apache/spark/pull/20458 IIRC extending App won't work, or didn't. The example is already correct. --- - To unsubscribe, e-mail:

[GitHub] spark issue #20458: changed scala example from java "style" to scala

Github user mantovani commented on the issue: https://github.com/apache/spark/pull/20458 I just changed to the right section. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20458: changed scala example from java "style" to scala

Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/20458 the example is written in Java, not in Scala. I think you can close this PR, thanks. --- - To unsubscribe, e-mail:

[GitHub] spark issue #20458: changed scala example from java "style" to scala

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20458 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20458: changed scala example from java "style" to scala

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20458 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional