[GitHub] spark issue #20632: [SPARK-3159] added subtree pruning in the translation fr...

2018-02-28 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/20632 @asolimando Can you change the title to include `[ML]` and also shorten it. Maybe just: `Add decision tree pruning` --- - To

[GitHub] spark issue #20632: [SPARK-3159] added subtree pruning in the translation fr...

2018-02-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20632 **[Test build #4136 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4136/testReport)** for PR 20632 at commit

[GitHub] spark issue #20632: [SPARK-3159] added subtree pruning in the translation fr...

2018-02-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20632 **[Test build #4136 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4136/testReport)** for PR 20632 at commit

[GitHub] spark issue #20632: [SPARK-3159] added subtree pruning in the translation fr...

2018-02-28 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/20632 @srowen Do we need you to trigger the tests? I'm not sure why they haven't been run... --- - To unsubscribe, e-mail:

[GitHub] spark issue #20632: [SPARK-3159] added subtree pruning in the translation fr...

2018-02-28 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/20632 Jenkins test this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20632: [SPARK-3159] added subtree pruning in the translation fr...

2018-02-27 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/20632 PS @sethah feel free to merge this one when you think it's ready. --- - To unsubscribe, e-mail:

[GitHub] spark issue #20632: [SPARK-3159] added subtree pruning in the translation fr...

2018-02-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20632 **[Test build #4103 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4103/testReport)** for PR 20632 at commit

[GitHub] spark issue #20632: [SPARK-3159] added subtree pruning in the translation fr...

2018-02-20 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20632 **[Test build #4103 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4103/testReport)** for PR 20632 at commit

[GitHub] spark issue #20632: [SPARK-3159] added subtree pruning in the translation fr...

2018-02-20 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/20632 Run `./dev/scalastyle` to replicate what Jenkins will do. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #20632: [SPARK-3159] added subtree pruning in the translation fr...

2018-02-20 Thread asolimando
Github user asolimando commented on the issue: https://github.com/apache/spark/pull/20632 Given that we are converging I have squashed the commits into a single one. My local `mvn scalastyle:check` was passing (as well as the check done via the Scala plugin for IntelliiJ)

[GitHub] spark issue #20632: [SPARK-3159] added subtree pruning in the translation fr...

2018-02-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20632 **[Test build #4100 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4100/testReport)** for PR 20632 at commit

[GitHub] spark issue #20632: [SPARK-3159] added subtree pruning in the translation fr...

2018-02-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20632 **[Test build #4100 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4100/testReport)** for PR 20632 at commit

[GitHub] spark issue #20632: [SPARK-3159] added subtree pruning in the translation fr...

2018-02-19 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/20632 Another one that @jkbradley or @MLnick might want to look at, but seems like a nice win. --- - To unsubscribe, e-mail:

[GitHub] spark issue #20632: [SPARK-3159] added subtree pruning in the translation fr...

2018-02-17 Thread asolimando
Github user asolimando commented on the issue: https://github.com/apache/spark/pull/20632 Hello Sean, here is my understanding of the problem and the main intuition of the proposed solution: We want to have a tree such that it does not contain any redundant subtree. A

[GitHub] spark issue #20632: [SPARK-3159] added subtree pruning in the translation fr...

2018-02-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20632 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20632: [SPARK-3159] added subtree pruning in the translation fr...

2018-02-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20632 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional