[GitHub] spark issue #20670: [SPARK-23405] Add constranits

2018-02-26 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/20670 Also, a better title for this PR would be: ``` Generate additional constraints for Join's children ``` --- - To

[GitHub] spark issue #20670: [SPARK-23405] Add constranits

2018-02-26 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/20670 Agree with that @cloud-fan proposed to have constraints for a plan and the children. However, that requires a relative wider change as well as a find set of test cases, please don't be hesitate

[GitHub] spark issue #20670: [SPARK-23405] Add constranits

2018-02-26 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20670 Good catch! This is a real problem, but the fix looks hacky. By definition, I think `plan.contraints` should only include constraints that refer to `plan.output`, as that's the promise a

[GitHub] spark issue #20670: [SPARK-23405] Add constranits

2018-02-25 Thread KaiXinXiaoLei
Github user KaiXinXiaoLei commented on the issue: https://github.com/apache/spark/pull/20670 @srowen i redescribe the problem. Now i hive a small table `ls` with one row , and a big table `catalog_sales` with One hundred billion rows. And in the big table, the non null value about

[GitHub] spark issue #20670: [SPARK-23405] Add constranits

2018-02-25 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/20670 This is still lacking detail about 'why'. It's not my area either. I think you should not have reopened this. --- - To

[GitHub] spark issue #20670: [SPARK-23405] Add constranits

2018-02-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20670 **[Test build #87651 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87651/testReport)** for PR 20670 at commit

[GitHub] spark issue #20670: [SPARK-23405] Add constranits

2018-02-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20670 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87651/ Test FAILed. ---

[GitHub] spark issue #20670: [SPARK-23405] Add constranits

2018-02-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20670 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20670: [SPARK-23405] Add constranits

2018-02-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20670 **[Test build #87651 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87651/testReport)** for PR 20670 at commit

[GitHub] spark issue #20670: [SPARK-23405] Add constranits

2018-02-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20670 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1038/

[GitHub] spark issue #20670: [SPARK-23405] Add constranits

2018-02-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20670 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20670: [SPARK-23405] Add constranits

2018-02-25 Thread KaiXinXiaoLei
Github user KaiXinXiaoLei commented on the issue: https://github.com/apache/spark/pull/20670 @SparkQA i think this error is not caused by my patch. please ok to test. --- - To unsubscribe, e-mail:

[GitHub] spark issue #20670: [SPARK-23405] Add constranits

2018-02-25 Thread KaiXinXiaoLei
Github user KaiXinXiaoLei commented on the issue: https://github.com/apache/spark/pull/20670 @srowen @wangyum help me review, thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #20670: [SPARK-23405] Add constranits

2018-02-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20670 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20670: [SPARK-23405] Add constranits

2018-02-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20670 **[Test build #87648 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87648/testReport)** for PR 20670 at commit

[GitHub] spark issue #20670: [SPARK-23405] Add constranits

2018-02-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20670 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87648/ Test FAILed. ---