Github user icexelloss commented on the issue:
https://github.com/apache/spark/pull/20728
LGTM too
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20728
Merged to master and branch-2.3.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/20728
LGTM.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20728
Will merge this one if there are no more comments in few days.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20728
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20728
**[Test build #87948 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87948/testReport)**
for PR 20728 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20728
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87948/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20728
**[Test build #87948 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87948/testReport)**
for PR 20728 at commit
Github user mstewart141 commented on the issue:
https://github.com/apache/spark/pull/20728
your test definitely makes sense; yea the syntax error in py2 part is why i
wasn't sure how to go about testing this in the first place. this certainly
gets the job done.
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20728
cc @ueshin, @BryanCutler, @icexelloss FYI.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20728
I was just double checking if we can write a test. Mind adding the test
below if it makes sense?
```diff
diff --git a/python/pyspark/sql/tests.py b/python/pyspark/sql/tests.py
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20728
Usually I leave it open for few days so that I or other reviewers can check
this change. I or other reviewers will leave some review comments, or leave an
approval on this PR if it looks good
Github user mstewart141 commented on the issue:
https://github.com/apache/spark/pull/20728
what should next step be here?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20728
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87938/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20728
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20728
**[Test build #87938 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87938/testReport)**
for PR 20728 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20728
**[Test build #87938 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87938/testReport)**
for PR 20728 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20728
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user mstewart141 commented on the issue:
https://github.com/apache/spark/pull/20728
cc @HyukjinKwon
ð
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20728
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20728
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
21 matches
Mail list logo
