[GitHub] spark issue #20880: [SPARK-23769][Core]Remove comments that unnecessarily di...

2018-03-23 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20880 Merged to master and branch-2.3. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20880: [SPARK-23769][Core]Remove comments that unnecessarily di...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20880 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20880: [SPARK-23769][Core]Remove comments that unnecessarily di...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20880 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88525/ Test PASSed. ---

[GitHub] spark issue #20880: [SPARK-23769][Core]Remove comments that unnecessarily di...

2018-03-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20880 **[Test build #88525 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88525/testReport)** for PR 20880 at commit [`b6088e2`](https://github.com/apache/spark/commit/b

[GitHub] spark issue #20880: [SPARK-23769][Core]Remove comments that unnecessarily di...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20880 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88526/ Test PASSed. ---

[GitHub] spark issue #20880: [SPARK-23769][Core]Remove comments that unnecessarily di...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20880 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20880: [SPARK-23769][Core]Remove comments that unnecessarily di...

2018-03-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20880 **[Test build #88526 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88526/testReport)** for PR 20880 at commit [`de5c33a`](https://github.com/apache/spark/commit/d

[GitHub] spark issue #20880: [SPARK-23769][Core]Remove comments that unnecessarily di...

2018-03-22 Thread arucard21
Github user arucard21 commented on the issue: https://github.com/apache/spark/pull/20880 Just pushed another fix for Scalastyle code checking. It just replaces a URL with a shortened version so we don't violate the max line length. Also tested with `./dev/lint-scala`. --- -

[GitHub] spark issue #20880: [SPARK-23769][Core]Remove comments that unnecessarily di...

2018-03-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20880 **[Test build #88526 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88526/testReport)** for PR 20880 at commit [`de5c33a`](https://github.com/apache/spark/commit/de

[GitHub] spark issue #20880: [SPARK-23769][Core]Remove comments that unnecessarily di...

2018-03-22 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20880 yea pease --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@sp

[GitHub] spark issue #20880: [SPARK-23769][Core]Remove comments that unnecessarily di...

2018-03-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20880 **[Test build #88525 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88525/testReport)** for PR 20880 at commit [`b6088e2`](https://github.com/apache/spark/commit/b6

[GitHub] spark issue #20880: [SPARK-23769][Core]Remove comments that unnecessarily di...

2018-03-22 Thread arucard21
Github user arucard21 commented on the issue: https://github.com/apache/spark/pull/20880 > let's include that change here. OK, I'll push the change in a few minutes. Should I close the other PR then? --- - T

[GitHub] spark issue #20880: [SPARK-23769][Core]Remove comments that unnecessarily di...

2018-03-22 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20880 let's include that change here. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark issue #20880: [SPARK-23769][Core]Remove comments that unnecessarily di...

2018-03-22 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20880 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@s

[GitHub] spark issue #20880: [SPARK-23769][Core]Remove comments that unnecessarily di...

2018-03-22 Thread arucard21
Github user arucard21 commented on the issue: https://github.com/apache/spark/pull/20880 @HyukjinKwon I had actually already created a separate branch for the other fix and was already creating a separate PR for it. So the other fix is in #20882. I also think that the typo in

[GitHub] spark issue #20880: [SPARK-23769][Core]Remove comments that unnecessarily di...

2018-03-22 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20880 ok to teat --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@s

[GitHub] spark issue #20880: [SPARK-23769][Core]Remove comments that unnecessarily di...

2018-03-22 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20880 That's fine. Let's invlove another insrance here. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For addi

[GitHub] spark issue #20880: [SPARK-23769][Core]Remove comments that unnecessarily di...

2018-03-22 Thread arucard21
Github user arucard21 commented on the issue: https://github.com/apache/spark/pull/20880 I just ran `./dev/lint-scala` as well and the result is `Scalastyle checks passed.` As I mentioned in the JIRA issue, we looked at all the instances of `scalastyle:off` comments in `spark

[GitHub] spark issue #20880: [SPARK-23769][Core]Remove comments that unnecessarily di...

2018-03-22 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20880 Also, I believe more correct way is `./dev/lint-scala` --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #20880: [SPARK-23769][Core]Remove comments that unnecessarily di...

2018-03-22 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20880 Minor change does't need a JIRA though. Mind checking if there are similar instances while we are here? --- - To unsubscribe