Github user dbtsai commented on the issue:
https://github.com/apache/spark/pull/20907
LGTM too! +1 on the documentation which can be a followup PR. Merged into
master, and thanks.
DB Tsai | Siri Open Source Technologies |  Apple, Inc
---
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20907
One question I have is, how do users know if a model (e.g. KMeansModel
after this change) supports pmml & internal formats? I did a search on the
current docs, but didn't find any info.
---
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20907
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/20907
Yup, this is ready. If you think its good feel free to merge it otherwise
I'll merge it during my regular Friday review time :)
---
