Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21165
thanks, merging to master!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21165
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21165
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90901/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21165
**[Test build #90901 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90901/testReport)**
for PR 21165 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21165
**[Test build #90901 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90901/testReport)**
for PR 21165 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21165
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user advancedxy commented on the issue:
https://github.com/apache/spark/pull/21165
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21165
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90891/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21165
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21165
**[Test build #90891 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90891/testReport)**
for PR 21165 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21165
**[Test build #90891 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90891/testReport)**
for PR 21165 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21165
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user advancedxy commented on the issue:
https://github.com/apache/spark/pull/21165
Gently ping @cloud-fan again.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21165
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21165
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90643/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21165
**[Test build #90643 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90643/testReport)**
for PR 21165 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21165
**[Test build #90643 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90643/testReport)**
for PR 21165 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21165
I think we can just update MimaExcludes, since it's developer API. cc
@JoshRosen
---
-
To unsubscribe, e-mail:
Github user advancedxy commented on the issue:
https://github.com/apache/spark/pull/21165
Looks like that simply add fields with default values into case class will
break binary compatibility.
How should we deal with that? Add to MimaExcludes or add missing methods?
@cloud-fan
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21165
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21165
**[Test build #90595 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90595/testReport)**
for PR 21165 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21165
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90595/
Test FAILed.
---
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21165
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21165
**[Test build #90595 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90595/testReport)**
for PR 21165 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21165
**[Test build #90585 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90585/testReport)**
for PR 21165 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21165
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90585/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21165
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21165
**[Test build #90585 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90585/testReport)**
for PR 21165 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21165
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user advancedxy commented on the issue:
https://github.com/apache/spark/pull/21165
ping @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user advancedxy commented on the issue:
https://github.com/apache/spark/pull/21165
@jiangxb1987 @cloud-fan I think it's ready for review.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user advancedxy commented on the issue:
https://github.com/apache/spark/pull/21165
> We should not do these 2 things together, and to me the second one is way
simpler to get in and we should do it first.
Agreed. For the scope of this pr, let's get killed tasks's
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21165
> For example user may want to record CPU time for every task and get the
total CPU time for the application.
The problem is, shall we allow end users to collect metrics via
Github user advancedxy commented on the issue:
https://github.com/apache/spark/pull/21165
> However, I don't agree user side accumulators should get updates from
killed tasks, that changes the semantic of accumulators. And I don't think
end-users need to care about killed tasks.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21165
I do agree task killed event should carry metrics update, as it's
reasonable to count killed tasks for something like how many bytes were read
from files.
However, I don't agree user
Github user advancedxy commented on the issue:
https://github.com/apache/spark/pull/21165
I add a note for accumulator update. Please comment if more document is
needed.
---
-
To unsubscribe, e-mail:
Github user advancedxy commented on the issue:
https://github.com/apache/spark/pull/21165
> It should be [Spark-20087] instead of [Spark 20087] in the title.
---
-
To unsubscribe, e-mail:
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/21165
It should be `[Spark-20087]` instead of `[Spark 20087]` in the title.
---
-
To unsubscribe, e-mail:
Github user advancedxy commented on the issue:
https://github.com/apache/spark/pull/21165
> we should document the changes in a migration document or something,
I think documentation is necessary, will update the documentation tomorrow
(Beijing time)
---
39 matches
Mail list logo
