Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/21278
Merging this to master and branch-2.3
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21278
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21278
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90468/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21278
**[Test build #90468 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90468/testReport)**
for PR 21278 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21278
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3109/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21278
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21278
**[Test build #90468 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90468/testReport)**
for PR 21278 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21278
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90439/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21278
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21278
**[Test build #90439 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90439/testReport)**
for PR 21278 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21278
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21278
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3094/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21278
**[Test build #90439 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90439/testReport)**
for PR 21278 at commit
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/21278
nice I like it... they also say
```
When specifying a minimum Java version please use the official version
names, which are (confusingly)
1.1 1.2 1.3 1.4 5.0 6 7 8 9 10
and
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/21278
it fails with
```
Quitting from lines 65-67 (sparkr-vignettes.Rmd)
Error: processing vignette 'sparkr-vignettes.Rmd' failed with diagnostics:
Java version check failed. Please
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21278
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90425/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21278
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21278
**[Test build #90425 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90425/testReport)**
for PR 21278 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21278
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3083/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21278
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/21278
Looking at http://r-pkgs.had.co.nz/description.html - `... the
SystemRequirements field. But this is just a plain text field and is not
automatically checked.` I think using `== 8` is probably
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21278
**[Test build #90425 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90425/testReport)**
for PR 21278 at commit
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/21278
I see yes, maybe grep for java version
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21278
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90397/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21278
**[Test build #90397 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90397/testReport)**
for PR 21278 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21278
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/21278
Ah I know the problem with the vignettes - if you have _JAVA_OPTIONS set
then the line numbers change. i.e. the output looks like
```
shivaram@localhost ~ » export
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/21278
```
Quitting from lines 65-67 (sparkr-vignettes.Rmd)
Error: processing vignette 'sparkr-vignettes.Rmd' failed with diagnostics:
Java version check failed
Execution halted
```
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21278
**[Test build #90399 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90399/testReport)**
for PR 21278 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21278
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90399/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21278
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21278
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3065/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21278
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/21278
yea, I don't think Spark builds on Java 9 (at least from what I've seen)
I see the package is gone from CRAN so the test results are brief but maybe
related to
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21278
**[Test build #90399 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90399/testReport)**
for PR 21278 at commit
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/21278
Ah got it - Thanks @HyukjinKwon . I'll check if `== 1.8` is supported by R
syntax
@felixcheung I moved the logic into a `checkJavaVersion` function now. Let
me know if this looks better.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21278
(I think Spark itself doesn't properly support Java 9 yet if I haven't
missed a discussion or thread)
---
-
To unsubscribe,
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/21278
Thats a fair question -- I initially created a script was to handle Windows
calls but I think we can do some of the split stuff inside R. Let me try that
out.
Regarding Java 9, do you
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/21278
also I think test fails on Java 9 - is there a way to exclude - doc sounds
like it's a minimal version
---
-
To
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21278
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21278
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3063/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21278
**[Test build #90397 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90397/testReport)**
for PR 21278 at commit
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/21278
The need for both the Requirements field and the runtime check is
documented at
https://cran.r-project.org/doc/manuals/r-release/R-exts.html#Writing-portable-packages
(Search for `Make sure that
43 matches
Mail list logo
