Github user HeartSaVioR commented on the issue:
https://github.com/apache/spark/pull/21388
I just provided new patch to remove the comment, as it looks like no longer
preferred option.
https://github.com/apache/spark/pull/21595
Closing this one.
---
Github user HeartSaVioR commented on the issue:
https://github.com/apache/spark/pull/21388
@hvanhovell
To be honest, I found the rationalization of the issue from a comment in
Spark code:
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/21388
@HeartSaVioR I really don't think we should automate these things at all.
The planner is a pretty critical component, and I'd rather be explicit on how a
`LogicalPlan` maps to a `SparkPlan` and
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21388
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21388
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HeartSaVioR commented on the issue:
https://github.com/apache/spark/pull/21388
@hvanhovell
I also think someone might not want to have reflection magic (I was the one
but realized I should do it), so I'm happy to close the PR when others voice
same opinion on this
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21388
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90952/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21388
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21388
**[Test build #90952 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90952/testReport)**
for PR 21388 at commit
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/21388
I donât think it is a good a idea to put reflection magic in the planner.
If you want to add cases to the planner please use the existing hooks
(SparkSessionExtensions, ExperimentalMethods or
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21388
**[Test build #90952 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90952/testReport)**
for PR 21388 at commit
Github user HeartSaVioR commented on the issue:
https://github.com/apache/spark/pull/21388
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21388
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21388
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90946/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21388
**[Test build #90946 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90946/testReport)**
for PR 21388 at commit
Github user HeartSaVioR commented on the issue:
https://github.com/apache/spark/pull/21388
Thanks @HyukjinKwon for reviewing. Addressed review comments.
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21388
**[Test build #90946 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90946/testReport)**
for PR 21388 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21388
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21388
**[Test build #90922 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90922/testReport)**
for PR 21388 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21388
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90922/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21388
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21388
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90924/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21388
**[Test build #90924 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90924/testReport)**
for PR 21388 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21388
**[Test build #90924 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90924/testReport)**
for PR 21388 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21388
**[Test build #90922 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90922/testReport)**
for PR 21388 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21388
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
26 matches
Mail list logo
