[GitHub] spark issue #21551: [K8S] Fix issue in 'docker-image-tool.sh'

2018-06-19 Thread foxish
Github user foxish commented on the issue: https://github.com/apache/spark/pull/21551 Phew, this was a bad one. Thanks for the fix all. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additiona

[GitHub] spark issue #21551: [K8S] Fix issue in 'docker-image-tool.sh'

2018-06-19 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/21551 FYI, PRs against non-master branches need to be manually closed. Don't know the exact explanation for why that's the case. --- -

[GitHub] spark issue #21551: [K8S] Fix issue in 'docker-image-tool.sh'

2018-06-19 Thread erikerlandson
Github user erikerlandson commented on the issue: https://github.com/apache/spark/pull/21551 @fabriziocucci can you close this PR? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional com

[GitHub] spark issue #21551: [K8S] Fix issue in 'docker-image-tool.sh'

2018-06-18 Thread erikerlandson
Github user erikerlandson commented on the issue: https://github.com/apache/spark/pull/21551 OK, I see it referenced above as commit b8dbfcc. I'd close this, but that option is disabled for me. Probably assuming it happens from the merge-pr script. --- -

[GitHub] spark issue #21551: [K8S] Fix issue in 'docker-image-tool.sh'

2018-06-18 Thread mccheah
Github user mccheah commented on the issue: https://github.com/apache/spark/pull/21551 Hm, I thought I did. I don't quite know what's going on. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For a

[GitHub] spark issue #21551: [K8S] Fix issue in 'docker-image-tool.sh'

2018-06-18 Thread mccheah
Github user mccheah commented on the issue: https://github.com/apache/spark/pull/21551 asfgit is showing the commit as pushed above. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional c

[GitHub] spark issue #21551: [K8S] Fix issue in 'docker-image-tool.sh'

2018-06-18 Thread erikerlandson
Github user erikerlandson commented on the issue: https://github.com/apache/spark/pull/21551 @mccheah this isn't showing as merged, you said you ran the merge script? --- - To unsubscribe, e-mail: reviews-unsubscr...

[GitHub] spark issue #21551: [K8S] Fix issue in 'docker-image-tool.sh'

2018-06-18 Thread fabriziocucci
Github user fabriziocucci commented on the issue: https://github.com/apache/spark/pull/21551 Duly noted! 👍 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: review

[GitHub] spark issue #21551: [K8S] Fix issue in 'docker-image-tool.sh'

2018-06-18 Thread mccheah
Github user mccheah commented on the issue: https://github.com/apache/spark/pull/21551 The PR is already merged so it's too late now. Next time, please create a ticket if one does not exist and put it in the PR description. --- ---