Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21564
LGTM except the test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21564
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21564
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91856/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21564
**[Test build #91856 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91856/testReport)**
for PR 21564 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21564
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21564
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91855/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21564
**[Test build #91855 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91855/testReport)**
for PR 21564 at commit
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/21564
@yucai thanks, can you please also add more UTs in order to cover all the
possible cases? Thanks.
---
-
To unsubscribe,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21564
**[Test build #91856 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91856/testReport)**
for PR 21564 at commit
Github user yucai commented on the issue:
https://github.com/apache/spark/pull/21564
@mgaido91 I update the codes as per your suggestion, thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user yucai commented on the issue:
https://github.com/apache/spark/pull/21564
@viirya I think`PartitioningCollection` should be considered. Like below
case:
```
spark.conf.set("spark.sql.autoBroadcastJoinThreshold", -1)
spark.conf.set("spark.sql.codegen.wholeStage",
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21564
**[Test build #91855 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91855/testReport)**
for PR 21564 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21564
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91829/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21564
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21564
**[Test build #91829 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91829/testReport)**
for PR 21564 at commit
Github user yucai commented on the issue:
https://github.com/apache/spark/pull/21564
@cloud-fan @viirya @gatorsmile , could you help review this?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21564
**[Test build #91829 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91829/testReport)**
for PR 21564 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21564
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21564
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
19 matches
Mail list logo
