[GitHub] spark issue #21580: [SPARK-24575][SQL] Prohibit window expressions inside WH...

2018-06-20 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/21580 Merging to master. Thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21580: [SPARK-24575][SQL] Prohibit window expressions inside WH...

2018-06-18 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/21580 LGTM. It is better UX to have a more descriptive error messages. However I do like the idea of being able to use window functions in filters. I often use the following pattern: ```sca

[GitHub] spark issue #21580: [SPARK-24575][SQL] Prohibit window expressions inside WH...

2018-06-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21580 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92010/ Test PASSed. ---

[GitHub] spark issue #21580: [SPARK-24575][SQL] Prohibit window expressions inside WH...

2018-06-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21580 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21580: [SPARK-24575][SQL] Prohibit window expressions inside WH...

2018-06-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21580 **[Test build #92010 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92010/testReport)** for PR 21580 at commit [`9a07ea3`](https://github.com/apache/spark/commit/9

[GitHub] spark issue #21580: [SPARK-24575][SQL] Prohibit window expressions inside WH...

2018-06-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21580 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21580: [SPARK-24575][SQL] Prohibit window expressions inside WH...

2018-06-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21580 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/4159/ Tes

[GitHub] spark issue #21580: [SPARK-24575][SQL] Prohibit window expressions inside WH...

2018-06-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21580 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/264/

[GitHub] spark issue #21580: [SPARK-24575][SQL] Prohibit window expressions inside WH...

2018-06-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21580 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21580: [SPARK-24575][SQL] Prohibit window expressions inside WH...

2018-06-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21580 **[Test build #92010 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92010/testReport)** for PR 21580 at commit [`9a07ea3`](https://github.com/apache/spark/commit/9a

[GitHub] spark issue #21580: [SPARK-24575][SQL] Prohibit window expressions inside WH...

2018-06-17 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21580 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h..

[GitHub] spark issue #21580: [SPARK-24575][SQL] Prohibit window expressions inside WH...

2018-06-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21580 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21580: [SPARK-24575][SQL] Prohibit window expressions inside WH...

2018-06-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21580 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92003/ Test FAILed. ---

[GitHub] spark issue #21580: [SPARK-24575][SQL] Prohibit window expressions inside WH...

2018-06-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21580 **[Test build #92003 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92003/testReport)** for PR 21580 at commit [`9a07ea3`](https://github.com/apache/spark/commit/9

[GitHub] spark issue #21580: [SPARK-24575][SQL] Prohibit window expressions inside WH...

2018-06-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21580 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/4154/ Tes

[GitHub] spark issue #21580: [SPARK-24575][SQL] Prohibit window expressions inside WH...

2018-06-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21580 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21580: [SPARK-24575][SQL] Prohibit window expressions inside WH...

2018-06-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21580 **[Test build #92003 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92003/testReport)** for PR 21580 at commit [`9a07ea3`](https://github.com/apache/spark/commit/9a

[GitHub] spark issue #21580: [SPARK-24575][SQL] Prohibit window expressions inside WH...

2018-06-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21580 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/259/

[GitHub] spark issue #21580: [SPARK-24575][SQL] Prohibit window expressions inside WH...

2018-06-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21580 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma