Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/21606
Given the deafening silence, I'll merge the PRs myself, given there's a
bunch of +1s from others.
---
-
To unsubscribe, e-mail:
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/21606
Cool, so it looks like we can merge this? (And #21615 and #21616?)
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21606
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21606
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92235/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21606
**[Test build #92235 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92235/testReport)**
for PR 21606 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21606
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92225/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21606
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21606
**[Test build #92225 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92225/testReport)**
for PR 21606 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21606
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21606
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/426/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21606
**[Test build #92235 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92235/testReport)**
for PR 21606 at commit
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/21606
Yeah so things like saveAsTextFile in 2.2 are ok but other functions like
saveAsNewAPIHadoopFile and the dataframe writers have the issue, so we do need
to backport
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21606
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92218/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21606
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21606
**[Test build #92218 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92218/testReport)**
for PR 21606 at commit
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/21606
Interesting. But I found the same code in a different place:
https://github.com/apache/spark/blob/branch-2.2/core/src/main/scala/org/apache/spark/internal/io/SparkHadoopMapReduceWriter.scala#L89
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/21606
just an fyi, I was looking at backporting to 2.2, looks like at least some
write calls don't have the issue:
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/21606
Also, since this patch won't backport, I'll go ahead and send versions of
it for branch-2.3 and branch-2.2 (which I think will be enough to also backport
to 2.1).
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21606
**[Test build #92225 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92225/testReport)**
for PR 21606 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21606
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/419/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21606
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/21606
A general comment about the log messages: it seems pretty noisy to have
"logInfo" messages for every task (doing so only in the "failure" paths would
be better in my opinion); but I'm keeping the
Github user rdblue commented on the issue:
https://github.com/apache/spark/pull/21606
+1
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/21606
+1
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21606
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21606
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92214/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21606
**[Test build #92214 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92214/testReport)**
for PR 21606 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21606
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/415/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21606
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21606
**[Test build #92218 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92218/testReport)**
for PR 21606 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21606
**[Test build #92214 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92214/testReport)**
for PR 21606 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21606
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/412/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21606
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/21606
test this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21606
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92192/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21606
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21606
**[Test build #92192 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92192/testReport)**
for PR 21606 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21606
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92190/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21606
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21606
**[Test build #92190 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92190/testReport)**
for PR 21606 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21606
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92189/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21606
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21606
**[Test build #92189 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92189/testReport)**
for PR 21606 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21606
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92187/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21606
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21606
**[Test build #92187 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92187/testReport)**
for PR 21606 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21606
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/394/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21606
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21606
**[Test build #92192 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92192/testReport)**
for PR 21606 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21606
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92181/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21606
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21606
**[Test build #92181 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92181/testReport)**
for PR 21606 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21606
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/391/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21606
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21606
**[Test build #92190 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92190/testReport)**
for PR 21606 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21606
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21606
**[Test build #92189 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92189/testReport)**
for PR 21606 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21606
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/389/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21606
**[Test build #92187 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92187/testReport)**
for PR 21606 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21606
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/388/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21606
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/21606
I guess it depends on how picky we want to be there are other places that
use attemptNumber that we could update to task id:
InternalRowDataWriterFactory, memoryV2, and SimpleWritableDataSource,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21606
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21606
**[Test build #92181 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92181/testReport)**
for PR 21606 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21606
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/384/
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/21606
Credit here should go to @rdblue when merging.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
66 matches
Mail list logo
