[GitHub] spark issue #21694: SPARK-24714 AnalysisSuite should use ClassTag to check t...

2018-07-02 Thread chia7712
Github user chia7712 commented on the issue: https://github.com/apache/spark/pull/21694 > I'm not sure this issue should be fixed for test code qualities though the bug is obvious but it doesn't impact the test case. At any rate, I'm ok to decline this PR :) ---

[GitHub] spark issue #21694: SPARK-24714 AnalysisSuite should use ClassTag to check t...

2018-07-02 Thread chia7712
Github user chia7712 commented on the issue: https://github.com/apache/spark/pull/21694 > I have one question; is this only a place having this issue?` I grepped the code base by "isInstanceOf[T]". Only one result appears and this PR have fixed it. ---

[GitHub] spark issue #21694: SPARK-24714 AnalysisSuite should use ClassTag to check t...

2018-07-02 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21694 I'm not sure this issue should be fixed for test code qualities though, I have one question; is this only a place having this issue? ---

[GitHub] spark issue #21694: SPARK-24714 AnalysisSuite should use ClassTag to check t...

2018-07-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21694 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21694: SPARK-24714 AnalysisSuite should use ClassTag to check t...

2018-07-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21694 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21694: SPARK-24714 AnalysisSuite should use ClassTag to check t...

2018-07-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21694 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional