Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21732
thanks, merging to master, great work!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99222/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21732
**[Test build #99222 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99222/testReport)**
for PR 21732 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21732
**[Test build #99222 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99222/testReport)**
for PR 21732 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99178/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21732
**[Test build #99178 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99178/testReport)**
for PR 21732 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99177/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21732
**[Test build #99177 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99177/testReport)**
for PR 21732 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21732
**[Test build #99178 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99178/testReport)**
for PR 21732 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21732
**[Test build #99177 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99177/testReport)**
for PR 21732 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21732
last comment, LGTM otherwise
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99090/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21732
**[Test build #99090 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99090/testReport)**
for PR 21732 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21732
**[Test build #99090 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99090/testReport)**
for PR 21732 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21732
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99063/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21732
**[Test build #99063 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99063/testReport)**
for PR 21732 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21732
**[Test build #99063 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99063/testReport)**
for PR 21732 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21732
LGTM except a few comments, good job!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98672/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21732
**[Test build #98672 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98672/testReport)**
for PR 21732 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21732
**[Test build #98672 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98672/testReport)**
for PR 21732 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98652/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21732
**[Test build #98652 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98652/testReport)**
for PR 21732 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21732
**[Test build #98652 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98652/testReport)**
for PR 21732 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21732
I think this is close, can you answer
https://github.com/apache/spark/pull/21732/files#r228782670 ?
---
-
To unsubscribe,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98445/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21732
**[Test build #98445 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98445/testReport)**
for PR 21732 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98440/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21732
**[Test build #98440 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98440/testReport)**
for PR 21732 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21732
**[Test build #98445 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98445/testReport)**
for PR 21732 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21732
**[Test build #98440 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98440/testReport)**
for PR 21732 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98146/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21732
**[Test build #98146 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98146/testReport)**
for PR 21732 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21732
**[Test build #98146 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98146/testReport)**
for PR 21732 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98131/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21732
**[Test build #98131 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98131/testReport)**
for PR 21732 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21732
**[Test build #98131 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98131/testReport)**
for PR 21732 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21732
Rebased this after refactoring ExpressionEncoder.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21732
Thanks. I've updated the PR description to summarize encoding of `Product`
and `Option[Product]`.
---
-
To unsubscribe, e-mail:
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21732
> Option[Product] is the same as Product except at top level?
Yeah, at top level, `Option[Product]` was not supported. After this change,
it is a struct type column.
---
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21732
> This doesn't make any change to Product.
yea I know, but we should put things together to evaluate a design.
After reading your description, `Option[Product]` is the same as
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21732
> For Product, normally it should be a struct type column, the special case
I can think of is: 1) at root level, flatten it into multiple columns, and the
Product can't be null.
> For
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21732
Since we have to handle some special cases, can you list them in the PR
description?
For `Product`, normally it should be a struct type column, the special case
I can think of is: 1) at
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97041/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21732
**[Test build #97041 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97041/testReport)**
for PR 21732 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21732
**[Test build #97041 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97041/testReport)**
for PR 21732 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21732
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97038/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21732
**[Test build #97038 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97038/testReport)**
for PR 21732 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21732
**[Test build #97038 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97038/testReport)**
for PR 21732 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/21732
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97027/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97030/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97029/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21732
**[Test build #97030 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97030/testReport)**
for PR 21732 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21732
**[Test build #97027 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97027/testReport)**
for PR 21732 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21732
**[Test build #97029 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97029/testReport)**
for PR 21732 at commit
1 - 100 of 252 matches
Mail list logo
